added validation for filtering and sorting in ReplaceAliasesWithPrope… #70
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ReplaceAliasesWithPropertyPaths simply replaces query aliases with their corresponding property paths, but it does not enforce any filtering or sorting restrictions defined in the QueryKitPropertyInfo.
This change adds a basic check to throw an exception when a user attempts to filter or sort on a property that is explicitly marked with CanFilter = false and CanSort = false.
(This PR is a quick fix that works for my specific scenario and is made to highlight the issue, but it's likely not suitable to merge as-is.)