Skip to content

ignore attributes which are supported by some plugins #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

ignore attributes which are supported by some plugins #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
230a3f6
ignore `variables` attribut which is supported by `decl_netcdf` but n…
Yushan-Wang Mar 12, 2025
22d5305
fix #558
Yushan-Wang Mar 12, 2025
b05b21d
update copyright date
Yushan-Wang Mar 18, 2025
bba5256
throw a warning if key is not recognized
Yushan-Wang Mar 19, 2025
b7396a0
update changelog
Yushan-Wang Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/decl_hdf5/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
[#419](https://gitlab.maisondelasimulation.fr/pdidev/pdi/-/issues/419)

### Changed
* Throw a waring instead of an error when a unknown key is parsed.

### Deprecated

Expand Down
4 changes: 2 additions & 2 deletions plugins/decl_hdf5/file_op.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (C) 2015-2024 Commissariat a l'energie atomique et aux energies alternatives (CEA)
* Copyright (C) 2015-2025 Commissariat a l'energie atomique et aux energies alternatives (CEA)
* Copyright (C) 2021-2022 Institute of Bioorganic Chemistry Polish Academy of Science (PSNC)
* All rights reserved.
*
Expand Down Expand Up @@ -102,7 +102,7 @@ vector<File_op> File_op::parse(Context& ctx, PC_tree_t tree)
} else if (key == "logging") {
// pass
} else {
throw Config_error{key_tree, "Unknown key in HDF5 file configuration: `{}'", key};
ctx.logger().warn("Unknown key in HDF5 file configuration: `{}'", key);
}
});

Expand Down