-
Notifications
You must be signed in to change notification settings - Fork 21
Limits / Keyword ID / Formating #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x
Are you sure you want to change the base?
Conversation
- Tests passing
The ES default is 100, however users can set their own config in ES
- New limit tests passing (?)
@use-the-fork - Limit-based tests are great. Inner hits hard limit has been set back to the original logic as per the commit message. In doing so, I also reset the two limit type methods from the query builder to see which of the tests would fail, but they are passing and seem to work as expected. Have a look to see if there's been an edge case missed somewhere. If so, please add it to the new limit tests so I can see it first-hand. Else GTG. New add-ons are great! |
@pdphilip This looks good to me! I just tested as well and everything passed. |
This PR includes:
Fixes:
InnerHits
.Adds:
pint.json
file.docker-compose
file for setting up Elasticsearch in dev when not using Nix.