Skip to content

Limits / Keyword ID / Formating #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: 5.x
Choose a base branch
from
Open

Limits / Keyword ID / Formating #66

wants to merge 12 commits into from

Conversation

use-the-fork
Copy link
Collaborator

This PR includes:

Fixes:

  • A bug where a limit wasn't being applied. @pdphilip, there's one TODO left for InnerHits.
  • A bug where IDs were treated as integers instead of strings, though they are stored as keywords.

Adds:

  • A GitHub workflow that auto-applies Pint formatting to PRs.
  • A default pint.json file.
  • A docker-compose file for setting up Elasticsearch in dev when not using Nix.

@use-the-fork use-the-fork requested a review from pdphilip as a code owner April 17, 2025 14:51
@pdphilip
Copy link
Owner

@use-the-fork - Limit-based tests are great.

Inner hits hard limit has been set back to the original logic as per the commit message. In doing so, I also reset the two limit type methods from the query builder to see which of the tests would fail, but they are passing and seem to work as expected. Have a look to see if there's been an edge case missed somewhere. If so, please add it to the new limit tests so I can see it first-hand. Else GTG.

New add-ons are great!

@use-the-fork
Copy link
Collaborator Author

@pdphilip This looks good to me! I just tested as well and everything passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants