Collect test coverage for both unit & NixOS integration tests #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieBuxton
previously approved these changes
Feb 17, 2024
elpdt852
force-pushed
the
feature/test-coverage
branch
2 times, most recently
from
37966da to
fb56221
Compare
elpdt852
force-pushed
the
feature/test-coverage
branch
from
fb56221 to
47256c8
Compare
|
Previously it was generating a coverage report per integration test. Using |
RobbieBuxton
approved these changes
Feb 17, 2024
|
Thanks, looks like our current statement-level test coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43
As of go 1.20, we can compile go binaries with cover instrumentation to collect coverage for integration tests: https://go.dev/doc/build-cover
Combined with
machine.copy_from_vmcapability via a shared mount in the NixOS test framework, we can essentially collect Golang test coverage data even when nix-snapshotter is embedded in a systemd service, very cool!We likely want to use codecov, which is free for open source (cc @gbpdt need approval for
pdtpartners/nix-snapshotter). For now, I've added the coverage data to$GITHUB_STEP_SUMMARY.