Fix mountpoints for nix store paths that are files #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpdt852
force-pushed
the
fix/file-store-path
branch
3 times, most recently
from
203d28d to
8fa484d
Compare
elpdt852
force-pushed
the
fix/file-store-path
branch
from
8fa484d to
ef8459a
Compare
- Refactor & add additional integration test coverage - Pin containerd to ensure compatible version - Add patch to enable loading compressed archives, i.e. loading images built from upstream `pkgs.dockerTools.buildImage` - Switch to nix-store to remove experimental "nix-command" dependency
elpdt852
force-pushed
the
fix/file-store-path
branch
from
ef8459a to
a147c1d
Compare
|
@RobbieBuxton @gbpdt This is ready for review now. |
RobbieBuxton
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #104
Fix #127
Summary
pkgs.dockerTools.buildImageEssentially I misunderstood that bind mounts for files needs to have an empty file as mountpoint instead of an empty base directory. This is now covered by unit & integration tests.
The integration tests were also refactored with newer patterns for handling rootless tests, and coverage for push/pull/load of nix-snapshotter &
dockerTools(upstream nixpkgs) images. Turns out there's a bug in containerd which is fixed by: containerd/containerd#9864 and currently maintained as patch in this repository. I've also opened a backport torelease/1.7here: containerd/containerd#9989