Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nixpkgs to attempt to fix golangci-lint #134

Closed
wants to merge 1 commit into from

Conversation

elpdt852
Copy link
Collaborator

@elpdt852 elpdt852 added the ok-to-test Runs NixOS tests label Mar 24, 2024
@RobbieBuxton
Copy link
Collaborator

Do you think it's worth going to unstable? I'm slightly warry about this after it caused some issues last time. We only need to wait 2 more months until nixos-24.05.

@elpdt852
Copy link
Collaborator Author

It also doesn’t fix the issue… closing for now.

@elpdt852 elpdt852 closed this Mar 24, 2024
@elpdt852 elpdt852 deleted the fix/golangci-lint branch March 24, 2024 10:52
@gbpdt
Copy link
Contributor

gbpdt commented Mar 24, 2024

We should probably use unstable and https://github.com/DeterminateSystems/update-flake-lock, that way we'll get a PR to review when upstream nixpkgs changes which will run the tests, and we can review before merging.

@RobbieBuxton
Copy link
Collaborator

We should probably use unstable and https://github.com/DeterminateSystems/update-flake-lock, that way we'll get a PR to review when upstream nixpkgs changes which will run the tests, and we can review before merging.

Oh that's very cool, yeah sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants