Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aarch64 to systems #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

outputs = inputs@{ nixpkgs, flake-parts, ... }:
flake-parts.lib.mkFlake { inherit inputs; } {
systems = [ "x86_64-linux" ];
systems = [ "x86_64-linux" "aarch64-linux" ];
imports = [ ./modules ];
};
}
10 changes: 6 additions & 4 deletions modules/nixos/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ in {
```
*/
flake.nixosConfigurations = {
vm = nixosSystemFor "x86_64-linux" ./vm.nix;
vm-rootless = nixosSystemFor "x86_64-linux" ./vm-rootless.nix;
vm-x86_64-linux = nixosSystemFor "x86_64-linux" ./vm.nix;
Copy link
Collaborator

@elpdt852 elpdt852 Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do something like x86_64-linux.vm.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is nicer, otherwise I think this is ready to merge!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump for @yu-re-ka, sorry if you've already seen this. Not sure if GitHub automatically notifies for comments.

vm-rootless-x86_64-linux = nixosSystemFor "x86_64-linux" ./vm-rootless.nix;
vm-aarch64-linux = nixosSystemFor "aarch64-linux" ./vm.nix;
vm-rootless-aarch64-linux = nixosSystemFor "aarch64-linux" ./vm-rootless.nix;
};

perSystem = { system, ... }: {
Expand All @@ -77,8 +79,8 @@ in {
```
*/
apps = {
vm = vmApp "vm";
vm-rootless = vmApp "vm-rootless";
vm = vmApp "vm-${system}";
vm-rootless = vmApp "vm-rootless-${system}";
};

# NixOS tests for nix-snapshotter.
Expand Down
Loading