fix: add lingering to rootless user tests #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @RobbieBuxton ! This looked like it was hard to diagnose but TIL about lingering. lgtm |
Signed-off-by: Robbie Buxton <[email protected]>
elpdt852
force-pushed
the
fix-local-test-failing
branch
from
e2c332f to
943ee12
Compare
elpdt852
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent the last couple of days trying to figure out why I wasn't able to locally get some tests to pass on my laptop.
It turns out that
systemdcan kill thealiceuser between waiting for the services to start and actually testing them due to the brief period where the user is unused.I assume this wasn't an issue on the test runners because they aren't a slow Chromebook so
systemdnever had an opportunity to cull thealiceuser. Either way this should make the tests more reliable!Changes
Enabled lingering for the
aliceusers in all rootless tests to stopsystemdculling them.Removed some dead code from and slightly refactored the snapshotter test.