Repository navigation
fix: Set historyEnabled only when modal state is pushed in AjaxModalExtension - #52
Merged
Merged
Conversation
…alExtension` Previously `historyEnabled` was set unconditionally to `true` in `buildState`, so unrelated naja requests using `data-naja-history="replace"` would mark history as enabled and later trigger `history.back()` from `hiddenHandler` when a non-ajax modal was closed, navigating the user out of the page. Now the flag mirrors `isShown`, matching whether a modal state was actually pushed/replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
historyEnabledwas set unconditionally totrueinbuildState, leaking across unrelated naja requestsisShown— the flag is only enabled when a modal state was actually pushed/replacedWhy
Unrelated naja requests using
data-naja-history="replace"would leavehistoryEnabled = true, andhiddenHandlerwould then callhistory.back()when a non-ajax modal was closed — navigating the user out of the page.Test plan
data-naja-history="replace"requestem + non-ajax modal — zavření modalu nesmí způsobit navigaci pryčhistory.back()