Repository navigation
fix: Normalize reserved pdModal snippets on snippet cache restore - #58
Merged
Merged
Conversation
…AjaxModalExtension` After a page refresh, Naja replaces the history state with a snapshot of the full page, where the modal skeleton is not present, so the reserved modal snippets are missing from the stored snippets. Missing reserved snippets are now filled with empty strings on `restore` the same way as in the payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AjaxModalExtensionnow fills missing reserved modal snippets with empty strings also on the snippet cacherestoreevent, not only onpayload.options.pdModalis available onrestore, becauseonSnippetFetchsets it on the sameoptionsobject before Naja dispatchesrestore.