Implicit temporal discretization for chemical source terms #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is to implement an implicit time step for the local (in space) part of the thermochemical evolution. To do this, we have to rearrange the code to enable evaluation of the chemical source terms at each point in space, rather than for the full field, so that we can update each point in space independently.
Creating an ability to evaluate source terms at a point in space.
The the implicit-chemistry option (bool) allows the user to turn on nonlinear, implicit solve for the chemistry update, while previous options are restored to their original meaning (i.e., preserving the original functionality).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an implicit (backward Euler for now) discretization of the chemical source term update within the operator split framework employed on the low Mach code path.