Skip to content

Implement hard link detection in directory size calculation #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parkervcp merged 1 commit into from
Jan 23, 2026
Merged

Implement hard link detection in directory size calculation #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions server/filesystem/disk_space.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package filesystem

import (
"golang.org/x/sys/unix"
"slices"
"sync"
"sync/atomic"
"time"
Expand Down Expand Up @@ -163,7 +165,9 @@ func (fs *Filesystem) DirectorySize(root string) (int64, error) {
if err != nil {
return 0, err
}


var hardLinks []uint64

var size atomic.Int64
err = fs.unixFS.WalkDirat(dirfd, name, func(dirfd int, name, _ string, d ufs.DirEntry, err error) error {
if err != nil {
Expand All @@ -180,9 +184,17 @@ func (fs *Filesystem) DirectorySize(root string) (int64, error) {
return errors.Wrap(err, "lstatat err")
}

// TODO: detect if info is a hard-link and de-duplicate it.
// ref; https://github.com/pelican-dev/wings/pull/181/files

var sysFileInfo = info.Sys().(*unix.Stat_t)
if sysFileInfo.Nlink > 1 {
// Hard links have the same inode number
if slices.Contains(hardLinks, sysFileInfo.Ino) {
// Don't add hard links size twice
return nil
} else {
hardLinks = append(hardLinks, sysFileInfo.Ino)
}
}

size.Add(info.Size())
return nil
})
Expand Down
Loading