-
Notifications
You must be signed in to change notification settings - Fork 60
Add TOML file parsing functionality #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add TOML file parsing functionality #164
Conversation
📝 WalkthroughWalkthroughThe pull request adds TOML configuration file support by promoting the go-toml library from an indirect to a direct dependency and implementing TOML parsing logic that reads TOML files, converts them to JSON for processing, and writes results back to TOML format. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code graph analysis (1)parser/parser.go (1)
🔇 Additional comments (6)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
parkervcp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I can appreciate some code reuse.
|
@vanlueckn If you want to make sure the build in the action for this works. I don't have anything that uses toml to est with. if @Kotori0629 could also validate that would be good. |
I will check the build and toml parsing in a few minutes. I have a rust based software running which uses toml config files. |
|
Does work for me |
|
This looks fine to me but just a question can you try it with the applied changes from #161 as json and yaml parsing can do strange things. If not that is also fine |
|
It's working normally! thx! |
This resolves issue #146
The toml parser uses the aleady existing indirect dependency and promotes it to a direct depencency.
The logic reuses the json parser logic.
I added it because i need toml parsing for some games.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.