docs+milestone updates: finish milestone 2/3 and auth logout by wauputr4 · Pull Request #34 · pendig/mizan

wauputr4 · 2026-05-11T08:54:40Z

Summary

Marked Milestone 2 database foundation as complete (migration coverage + idempotent behavior already validated).
Marked Milestone 3 auth/API-keys milestone as complete.
Added POST /auth/logout endpoint for session revocation.
Kept implementation and docs in milestone-aligned crates (crates/mizan-api/src/auth.rs, crates/mizan-api/src/lib.rs, docs/BACKEND_IMPLEMENTATION_PLAN.md, docs/ISSUE_BACKLOG.md).
Validation:
- cargo test --workspace -- --nocapture pass.
- Local smoke flow checked: register/login/logout and token invalidation after logout.

References

Mizan roadmap milestones:
- Issue 2 (database foundation)
- Issue 3 (auth + API keys)

GitHub issues for next milestones

P5: Implement streaming chat completions gateway
P5: Normalize upstream errors and provider health state
P6: Record usage events from completed gateway requests
P6: Add balance safety and token estimation fallback
P6: Implement ledger-first credit grants and usage charges
P7: Implement Redis RPM, TPM, and concurrency primitives
P7: Enforce insufficient-credit and limit error responses
P8: Add Prometheus metrics endpoint
P8: Harden structured tracing and log redaction

wauputr4 · 2026-05-11T08:56:17Z

@codex review

gemini-code-assist

Code Review

This pull request implements the logout functionality by adding a new /auth/logout endpoint and its corresponding handler in auth.rs. It also updates the project documentation and README to reflect the completion of Milestones 2 and 3. Feedback was provided regarding the logout handler's response behavior; it is recommended to return a 401 Unauthorized status instead of a 200 OK when a session token is invalid or already revoked to maintain consistency with other authenticated endpoints.

chatgpt-codex-connector · 2026-05-11T08:59:25Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wauputr4 · 2026-05-11T09:17:01Z

/gemini review

wauputr4 · 2026-05-11T09:17:07Z

@codex review

gemini-code-assist

Code Review

This pull request implements the logout functionality, adding a new API route and database logic to revoke session tokens. It also updates the project documentation and README to reflect the completion of Milestones 2 and 3. Feedback suggests removing hardcoded commit hashes and ephemeral phrases from the documentation to improve maintainability. Additionally, it is recommended to make the logout operation idempotent by returning a success status even if the session has already been revoked, rather than a 401 Unauthorized error.

chatgpt-codex-connector · 2026-05-11T09:19:34Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64963c0d24

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wauputr4 · 2026-05-11T09:43:07Z

Update: sudah saya implement perbaikan review yang tersisa.

gateway: header parser sekarang toleran untuk x-request-id/x-trace-id yang non-UUID dan tetap generate UUID server.
gateway: response error kini dibangun via helper agar x-request-id + x-trace-id tetap ikut di error path.
auth: POST /auth/logout jadi idempotent (revoked: false jika sesi sudah revoked/tidak ketemu, sukses return tetap 200).
docs: hapus hardcoded commit hash / frase this pass di status milestone.

Commit: bcb860d.

Silakan cek review threads; revisi baru sudah di-push sehingga thread lama seharusnya jadi outdated/resolved by context.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2513479da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60d826bf37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Implements PR #34 follow-ups for true end-to-end SSE forwarding and multi-line SSE data parsing. Covers #35 and #36.

wauputr4 · 2026-05-11T21:55:44Z

Update: implemented the PR #34 streaming review follow-ups in aba5455.

P5: Stream chat completion chunks end-to-end without buffering #35: provider streaming now reads upstream bytes incrementally and gateway SSE no longer collects the full stream before responding.
P5: Support multi-line SSE data fields in provider stream parser #36: SSE parser now joins repeated data: fields with newline separators before JSON decoding.
Added tests for incremental provider/gateway emission and multi-line SSE parsing.

Verification is green locally and in CI:

cargo fmt
cargo clippy --workspace --all-targets -- -D warnings
cargo test --workspace
smoke GET /healthz on 127.0.0.1:18281
GitHub Actions CI run 25699537547: success

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aba5455e67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7db7f1c070

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-12T01:45:03Z

+    let mut content = String::new();
+    if let Some(first_choice) = response.choices.into_iter().next() {
+        content = first_choice
+            .message
+            .and_then(|message| message.content)
+            .unwrap_or_default();
+    }


Reject chat completions that contain no choices

If the upstream returns HTTP 200 with an empty choices array, this parser falls back to content = "" and the gateway emits a normal successful completion instead of surfacing a provider error. In that scenario clients receive a false-success response (empty assistant message) and cannot distinguish malformed upstream output from a real completion, which can silently corrupt downstream behavior and accounting.

Useful? React with 👍 / 👎.

wauputr4 added 2 commits May 11, 2026 09:32

docs: mark milestone 2 database foundation complete

0be31d6

feat: add session logout endpoint for auth milestone

da6bc6a

wauputr4 marked this pull request as ready for review May 11, 2026 08:56

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

Comment thread crates/mizan-api/src/auth.rs Outdated

fix(api): return 401 when logout token invalid

3d76ae3

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

Comment thread docs/BACKEND_IMPLEMENTATION_PLAN.md Outdated

Comment thread docs/BACKEND_IMPLEMENTATION_PLAN.md Outdated

Comment thread docs/ISSUE_BACKLOG.md Outdated

Comment thread docs/ISSUE_BACKLOG.md Outdated

Comment thread crates/mizan-api/src/auth.rs Outdated

feat(api): implement chat completion streaming and request tracing

64963c0

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread crates/mizan-api/src/gateway.rs Outdated

Comment thread crates/mizan-api/src/gateway.rs Outdated

fix(api): improve chat completion error tracing and docs phrasing

bcb860d

feat(api): implement upstream chat streaming

e251347

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread crates/mizan-api/src/gateway.rs Outdated

Comment thread crates/mizan-providers/src/lib.rs Outdated

fix(clippy): simplify stream parser checks

60d826b

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread crates/mizan-providers/src/lib.rs

This was referenced May 11, 2026

P5: Stream chat completion chunks end-to-end without buffering #35

Open

P5: Support multi-line SSE data fields in provider stream parser #36

Open

P5: Implement streaming chat completions gateway #19

Open

fix(streaming): forward chat chunks incrementally

aba5455

Implements PR #34 follow-ups for true end-to-end SSE forwarding and multi-line SSE data parsing. Covers #35 and #36.

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread crates/mizan-api/src/gateway.rs Outdated

fix(streaming): avoid [DONE] after upstream error

7db7f1c

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

Conversation

wauputr4 commented May 11, 2026

Summary

References

GitHub issues for next milestones

Uh oh!

wauputr4 commented May 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented May 11, 2026

Uh oh!

wauputr4 commented May 11, 2026

Uh oh!

wauputr4 commented May 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

wauputr4 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wauputr4 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant