-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
umpf: add new --override option to override topic commit-ish #24
Conversation
2d5c067
to
0d85f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part. One small change, then it should be ready.
@michaelolbrich I am thinking of whether we might want to increase
This would make it more useful to cover two common cases I have: Someone umpf'd a release and I want to either override a single topic branch that exists or to add a single branch into the umpf. The alternative for the latter is currently cumbersome:
|
I like the idea in general but I think we should have two separate options for this. |
0d85f72
to
4bcd4e2
Compare
4bcd4e2
to
e7c3c12
Compare
I had changed the syntax from Anyway, I forgot about that and tried to use umpf --override today and found that I broke error handling:
used elsewhere in umpf, does just that, so I force pushed this single change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just minor stuff in the help text.
In one project, umpf tags are pushed immediately, but branches are only pushed upstream once they are reviewed and cleared for merge into BSP. It's thus often the case, that developers want to use the upstream branches, except for that one branch they are currently working on. This is not an unusual case and the tips-and-tricks lists some workarounds to achieve this. Provide a better way by allowing overriding single topic branches on the command-line. Signed-off-by: Ahmad Fatoum <[email protected]>
e7c3c12
to
744713c
Compare
In one project, umpf tags are pushed immediately, but branches are only pushed upstream once they are reviewed and cleared for merge into BSP. It's thus often the case, that developers want to use the upstream branches, except for that one branch they are currently working on.
This is not an unusual case and the tips-and-tricks lists some workarounds to achieve this. Provide a better way by allowing overriding single topic branches on the command-line.