Skip to content

Conversation

jonathankao97
Copy link
Contributor

No description provided.

@jonathankao97
Copy link
Contributor Author

jonathankao97 commented Apr 4, 2022

View admin UI using (admin, default password from second command):

kubectl port-forward svc/argo-cd-argocd-server -n argocd 8080:443
kubectl -n argocd get secret argocd-initial-admin-secret -o jsonpath="{.data.password}" | base64 -d; echo

Functionality:

  • Syncs all manifests available in the pennlabs/kube-manifests repository
  • If a namespace is not defined in the k8s manifest, falls back to namespace defined in server.additionalApplications.destination.namespace

Current bug:

Duplicate manifests:

@jonathankao97 jonathankao97 requested a review from ArmaanT April 4, 2022 04:13
@ArmaanT
Copy link
Member

ArmaanT commented Apr 5, 2022

Just to make sure I'm understanding it correctly, for the duplicated manifests, if I have two identical YAML copies of a certificate, argo will output a warning but still sync them, and if I delete one instance, it won't delete the certificate?

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (efd8251) to head (e9a815f).
Report is 46 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          31       31           
  Lines         433      433           
  Branches       86       86           
=======================================
  Hits          426      426           
  Misses          5        5           
  Partials        2        2           
Flag Coverage Δ
kittyhawk 97.34% <ø> (ø)
kraken 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArmaanT
Copy link
Member

ArmaanT commented Apr 17, 2022

A couple more questions:

  1. Is kube-manifests repo supposed to be private? If so, we'll have to update the terraform and give argo credentials to access it.
  2. Are we planning on setting up a webhook so that argo doesn't have to keep polling the kube-manifests repo?

@joyliu-q
Copy link
Contributor

closing due to inactivity

@joyliu-q joyliu-q closed this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants