Skip to content

VSW-306: Implement sockdma device#19

Merged
lizzi-xlnx merged 1 commit intopensando:v8.2.0-devfrom
ligallag-amd:user/ligallag/mctp_emu
Jul 22, 2025
Merged

VSW-306: Implement sockdma device#19
lizzi-xlnx merged 1 commit intopensando:v8.2.0-devfrom
ligallag-amd:user/ligallag/mctp_emu

Conversation

@ligallag-amd
Copy link
Copy Markdown

@ligallag-amd ligallag-amd commented Jul 2, 2025

This work builds on top of Leo's work: #18 to fix a couple bugs in the device.

Testing

See https://github.com/pensando/ainic-rtos/pull/47

@ligallag-amd ligallag-amd force-pushed the user/ligallag/mctp_emu branch from cec5c51 to c3bf94f Compare July 11, 2025 10:02
@ligallag-amd
Copy link
Copy Markdown
Author

Force push adds recv_status and send_status registers to replace the status register. This prevents a send which reads the status register from also consuming the receive data also present on the socket.

Copy link
Copy Markdown
Collaborator

@lizzi-xlnx lizzi-xlnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd start cleaning up the commits for review so that then the PR is ready for master.

Comment on lines +14 to +15
uint32_t recv_status;
uint32_t send_status;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have two different status registers?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I should've put a justification here. See this comment I made https://github.com/pensando/ainic-rtos/pull/47#issuecomment-3061633285

@ligallag-amd ligallag-amd force-pushed the user/ligallag/mctp_emu branch from c3bf94f to 92bd23a Compare July 21, 2025 13:52
@ligallag-amd
Copy link
Copy Markdown
Author

force push squashes and updates commit message

@ligallag-amd ligallag-amd changed the title VSW-316: Exercise sockdma driver VSW-306: Implement sockdma device Jul 21, 2025
Create nonblocking socket to pass data between firmware running on qemu
and host software. On 'read_status' register read, poll the socket for
rx data and write it to a memory mapped region accessible by firmware.
Sends read data populated in this region by the firmare and send it
through the socket.
@ligallag-amd ligallag-amd force-pushed the user/ligallag/mctp_emu branch from 92bd23a to ba18d09 Compare July 21, 2025 14:27
@lizzi-xlnx lizzi-xlnx merged commit f53c012 into pensando:v8.2.0-dev Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants