PBM-1663: Support profile flags for list and status commands #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcechace
changed the title
Collaborator
Author
|
@boris-ilijic This should be ready for review |
boris-ilijic
approved these changes
Dec 5, 2025
Member
boris-ilijic
left a comment
boris-ilijic
left a comment
There was a problem hiding this comment.
LGTM, although there is small issue in PITR UI.
Also, we cannot filter only by main storage, which can be useful, but we can add that later also.
| s.Path = cfg.Storage.Path() | ||
|
|
||
| bcps, err := pbm.GetAllBackups(ctx) | ||
| bcps, err := backup.BackupsList(ctx, conn, profile, 0) |
Member
There was a problem hiding this comment.
This filtered backup list doesn't contain base backups for PITR, and then PBM shows something like:
pbm s --profile s3
Snapshots:
2025-12-05T13:29:01Z 270.03KB <logical, s3> success [restore_to_time: 2025-12-05T13:29:05]
PITR chunks [7.51MB]:
2025-12-05T13:25:32 - 2025-12-05T16:00:52
2025-12-05T13:24:29 - 2025-12-05T13:25:31 (no base snapshot) <--
The best should be to omit the list of PITR in case of --profile, so the same as we do for list. Or pass down the full list of backups, so that it's possible to make that resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pbm list --profile=abcfor which only backups inabcprofile are listed, PITR section is entirely omitted (regardless of PITR state or chunks in the default storage)pbm status --profile=abcfor which it only lists backups inabcprofile, only affects the "backups" section of the status, everything else is unchangedBackupList