PMM-13171 Add ClickHouse credentials #3646
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3646 +/- ##
==========================================
+ Coverage 43.62% 43.65% +0.03%
==========================================
Files 366 366
Lines 44328 44343 +15
==========================================
+ Hits 19338 19360 +22
+ Misses 23310 23302 -8
- Partials 1680 1681 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
BupycHuk,
idoqo and
JiriCtvrtka
and removed request for
a team
| @@ -138,7 +138,7 @@ | |||
| <!-- Compatibility with MySQL protocol. | |||
| ClickHouse will pretend to be MySQL for applications connecting to this port. | |||
| --> | |||
| <mysql_port>9004</mysql_port> | |||
| <!-- <mysql_port>9004</mysql_port> --> | |||
There was a problem hiding this comment.
We likely don't need to have that many ports open. Please review this.
There was a problem hiding this comment.
we don't use it that way I think - so fair point.
| <allow_plaintext_password>1</allow_plaintext_password> | ||
| <allow_no_password>1</allow_no_password> | ||
| <allow_implicit_no_password>1</allow_implicit_no_password> | ||
| <allow_plaintext_password>0</allow_plaintext_password> |
There was a problem hiding this comment.
This will harden security, for it was too poor before.
| @@ -138,7 +138,7 @@ | |||
| <!-- Compatibility with MySQL protocol. | |||
| ClickHouse will pretend to be MySQL for applications connecting to this port. | |||
| --> | |||
| <mysql_port>9004</mysql_port> | |||
| <!-- <mysql_port>9004</mysql_port> --> | |||
There was a problem hiding this comment.
we don't use it that way I think - so fair point.
PMM-13171
Link to the Feature Build: SUBMODULES-3847