PS-10419 [DOCS] - update js_lang documents with memory limits 8.4 #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
patrickbirch
commented
Dec 29, 2025
patrickbirch
commented
patrickbirch
force-pushed
the
ps-10419-8.4
branch
from
81fdc3c to
c03a279
Compare
patrickbirch
force-pushed
the
ps-10419-8.4
branch
from
c03a279 to
8cd15bc
Compare
patrickbirch
force-pushed
the
ps-10419-8.4
branch
from
8cd15bc to
c1320e4
Compare
dlenev
suggested changes
Jan 6, 2026
Collaborator
dlenev
left a comment
dlenev
left a comment
There was a problem hiding this comment.
Hello Patrick!
I think descriptions of hard and soft memory limits require adjustment.
patrickbirch
force-pushed
the
ps-10419-8.4
branch
from
c1320e4 to
5b50d47
Compare
dlenev
suggested changes
Jan 6, 2026
Collaborator
dlenev
left a comment
dlenev
left a comment
There was a problem hiding this comment.
Hello Patrick!
A few more comments from me.
|
|
||
| This variable controls the hard limit for JS routine memory allocation. When set to a non-zero value, the component calculates the hard limit as `js_lang.max_mem_size * js_lang.max_mem_size_hard_limit_factor` in bytes. | ||
|
|
||
| When a JS session's memory usage reaches the hard limit threshold, V8 triggers out-of-memory (OOM) handling, which terminates and crashes the entire mysqld process. This is different from the soft limit behavior, where V8 Isolate Termination stops only the JS execution and returns an error to the client. |
Collaborator
There was a problem hiding this comment.
Perhaps also mention here the last chance GC before crashing process which you describe above?
modified: docs/install-js-lang.md modified: docs/js-lang-overview.md modified: docs/js-lang-privileges.md modified: docs/js-lang-procedures.md modified: docs/js-lang-troubleshoot.md modified: docs/js-lang-variables.md modified: docs/uninstall-js-lang.md
patrickbirch
force-pushed
the
ps-10419-8.4
branch
from
5b50d47 to
7ab4674
Compare
dlenev
approved these changes
Jan 8, 2026
Collaborator
dlenev
left a comment
dlenev
left a comment
There was a problem hiding this comment.
Hi Patrick!
After the latest changes the proposed PR looks OK to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.