Skip to content

Use localizedInfoDictionary instead of infoDictionary #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoneeJohn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use localizedInfoDictionary instead of infoDictionary #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b390dd9
Use `localizedInfoDictionary` instead of `infoDictionary`
SoneeJohn Apr 23, 2020
3a28c4d
Use `-objectForInfoDictionaryKey:` to retrieve bundle values
SoneeJohn Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions PFAboutWindow/PFAboutWindowController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,23 +78,23 @@ - (void)windowDidLoad {
[self.visitWebsiteButton.cell setHighlightsBy:NSContentsCellMask];

// Load variables
NSDictionary *bundleDict = [[NSBundle mainBundle] infoDictionary];
NSBundle *mainBundle = [NSBundle mainBundle];

// Set app name
if(!self.appName) {
self.appName = [bundleDict objectForKey:@"CFBundleName"];
self.appName = [mainBundle objectForInfoDictionaryKey:@"CFBundleName"];
}

// Set app version
if(!self.appVersion) {
NSString *version = [bundleDict objectForKey:@"CFBundleVersion"];
NSString *shortVersion = [bundleDict objectForKey:@"CFBundleShortVersionString"];
NSString *version = [mainBundle objectForInfoDictionaryKey:@"CFBundleVersion"];
NSString *shortVersion = [mainBundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"];
self.appVersion = [NSString stringWithFormat:NSLocalizedString(@"Version %@ (Build %@)", @"Version %@ (Build %@), displayed in the about window"), shortVersion, version];
}

// Set copyright
if(!self.appCopyright) {
self.appCopyright = [[NSAttributedString alloc] initWithString:[bundleDict objectForKey:@"NSHumanReadableCopyright"] attributes:@{
self.appCopyright = [[NSAttributedString alloc] initWithString:[mainBundle objectForInfoDictionaryKey:@"NSHumanReadableCopyright"] attributes:@{
NSFontAttributeName:[NSFont fontWithName:@"HelveticaNeue" size:11]/*/NSParagraphStyleAttributeName : paragraphStyle*/}];
}

Expand Down