fix: geohash online count accuracy and channel switch latency#672
Open
moehamade wants to merge 1 commit intopermissionlesstech:mainfrom
Open
fix: geohash online count accuracy and channel switch latency#672moehamade wants to merge 1 commit intopermissionlesstech:mainfrom
moehamade wants to merge 1 commit intopermissionlesstech:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18f54d33f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
app/src/main/java/com/bitchat/android/nostr/GeohashRepository.kt
Outdated
Show resolved
Hide resolved
- Keep max lastSeen per user so relay's newest-first delivery doesn't overwrite a fresh timestamp with a stale one - Serialize event processing on Main dispatcher to eliminate ConcurrentModificationException on geohashParticipants maps - Immediately refresh people list on channel switch so sampling data is reflected before the first relay response arrives
moehamade
force-pushed
the
fix/geohash-online-count
branch
from
18f54d3 to
9528f50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastSeen, pushing them past the 5-minute cutoff and dropping them from the count. Fix: only updatelastSeenwhen the incoming timestamp is strictly newer.Dispatchers.Default(thread pool), causing concurrent coroutines to hit the sameHashMapwithiterator()+put()simultaneously. The resultingConcurrentModificationExceptionwas swallowed by the catch block, so heartbeat updates were silently dropped — only less-frequent chat messages updated the count reliably. Fix: process events onviewModelScope's default dispatcher (Main), which is single-threaded.currentGeohashbut never calledrefreshGeohashPeople(), so the header count waited for a relay round-trip even though sampling subscriptions had already populated participant data for that channel. Fix: callrefreshGeohashPeople()immediately aftersetCurrentGeohash().Test plan