Allow private message content to exceed 255 bytes#784
Open
hamzaozturk wants to merge 2 commits intopermissionlesstech:mainfrom
Open
Allow private message content to exceed 255 bytes#784hamzaozturk wants to merge 2 commits intopermissionlesstech:mainfrom
hamzaozturk wants to merge 2 commits intopermissionlesstech:mainfrom
Conversation
Collaborator
|
this is a protocol breaking change that we need to sync with android. it also has an error when message is exactly 255 chars. and no tests. |
Author
|
Is there any particular reason why private messages are limited to 255 characters? Just wondering if that’s intentional. |
Collaborator
|
arbitrary. i’ll sync with android team.
… On 10 Oct 2025, at 11:36, Hamza Öztürk ***@***.***> wrote:
hamzaozturk left a comment (permissionlesstech/bitchat#784)
Is there any particular reason why private messages are limited to 255 characters? Just wondering if that’s intentional.
Also, I’ve fixed the 255-char issue you mentioned and added the relevant tests for it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
…add unit tests for encoding/decoding
eb9bc80 to
cbdc880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary