-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export command #54
export command #54
Conversation
permitcli.mp4 |
Hey @daveads, seems like the CI failed due to build/lint/test issues, can you please test it? |
okayy |
@gemanor waiting for workflow approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, in general this is a good start, but it has some core changes needed.
Please see the comments in the code itself, and also address the following:
- The hooks/components shouldn't be in the
command
folder. Please use the othercomponents
/hooks
folders for them - The HCL should have a better templating solution. It is better that they will be in
.hcl
files, and you'll use a template engine to render them. Some of the code that is rendering now - Some of the content now is rendered as
object object
instead of good stringify solution - Please run some tests with files that you exported and import it again using TF to ensure the exported file is indeed valid
- There is no support with the
depends_on
for the resources, it could lead to race condition when working with terraform. Please adddepends_on
where relevant
alright |
React Hook useEffect has missing dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall structure looks good, and I like the approach you take in high-level.
In deeper look, there are many functions with too much intentation/lines. Left comments where it's not readable/testable and must refactor for better readability/testability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
feat: add terraform environment export command
permit env export terraform
command/claim #47