Command: import tf #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
|
@gemanor pretty much added... some test will be added by tomorrow so you can check on this after that. |
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
|
The coverage is only shown for the modified files in the below picture..
|
gemanor
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Great start! I merged the server and deployed it.
Left some comment, and also sent you some in Slack (attaching them here too)
- The local flow has a typo, and it actually does not run at all, even after fixing the typo (I attached the error in the CR)
- When the server starts running, the dropdown of the template list is still active, and the user has no indication of the server being called. After choosing the template, it should show the loader that the template applied is now running and hide the dropdown.
- After the command is complete to run, the process does not exist
|
@gemanor let me check these and update you when this are ready. |
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
|
@gemanor I have tested with some other commands which use I had run |
gemanor
reviewed
Mar 16, 2025
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
Signed-off-by: Abinand P <[email protected]>
gemanor
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.