Skip to content

Fix Arrow decimal type conversion to float instead of integer #3099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashwantbezawada wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Arrow decimal type conversion to float instead of integer #3099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/perspective-python/perspective/tests/table/test_table_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def test_table_arrow_loads_decimal_stream(self, util):
tbl = Table(arrow_data)
assert tbl.size() == 10
assert tbl.schema() == {
"a": "integer",
"a": "float",
}
assert tbl.view().to_columns() == {"a": data[0]}

Expand Down Expand Up @@ -389,7 +389,7 @@ def test_table_arrow_loads_decimal128_legacy(self, util):
tbl = Table(arrow_data)
assert tbl.size() == 10
assert tbl.schema() == {
"a": "integer",
"a": "float",
}
assert tbl.view().to_columns() == {"a": data[0]}

Expand Down
18 changes: 9 additions & 9 deletions rust/perspective-server/cpp/perspective/src/cpp/arrow_loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,12 @@ convert_type(const std::string& src) {
if (src == "uint64") {
return DTYPE_UINT64;
}
if (src == "decimal" || src == "decimal128" || src == "int64") {
if (src == "int64") {
return DTYPE_INT64;
}
if (src == "decimal" || src == "decimal128") {
return DTYPE_FLOAT64;
}
if (src == "float") {
return DTYPE_FLOAT32;
}
Expand Down Expand Up @@ -750,16 +753,13 @@ copy_array(
case arrow::Decimal128Type::type_id:
case arrow::DecimalType::type_id: {
std::shared_ptr<arrow::Decimal128Array> scol =
std::static_pointer_cast<arrow::DecimalArray>(src);
std::static_pointer_cast<arrow::Decimal128Array>(src);
auto decimal_type =
std::static_pointer_cast<arrow::Decimal128Type>(src->type());
int32_t scale = decimal_type->scale();
auto* vals = (arrow::Decimal128*)scol->raw_values();
for (uint32_t i = 0; i < len; ++i) {
arrow::Status status =
vals[i].ToInteger(dest->get_nth<int64_t>(offset + i));
if (!status.ok()) {
PSP_COMPLAIN_AND_ABORT(
"Could not write Decimal to column: " + status.message()
);
};
dest->set_nth<double>(offset + i, vals[i].ToDouble(scale));
}
} break;
case arrow::BooleanType::type_id: {
Expand Down