Made it possible to use via package managers & fixed subtypes of atomic types#6
Open
GeeWee wants to merge 14 commits into
Open
Made it possible to use via package managers & fixed subtypes of atomic types#6GeeWee wants to merge 14 commits into
GeeWee wants to merge 14 commits into
Conversation
added 14 commits
October 16, 2018 08:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
I added init.py to the typescript packages, and edited setup.py to include .ts files.
This does mean a init.py is copied into the typescript dir, but I didn't have time to provide a better fix.
While testing I ran into an issue where I had a field that was a Subclass of DateTimeField, which couldn't be used as a key into the ATOMIC_TYPES dict. Now we resolve atomic types via looping through the dict and doing an instanceof checks, to guard against this behaviour.