Make review feedback editable and newest-first - #32
Open
chinkeikk wants to merge 1 commit into
Open
Conversation
Add explicit comment editing, order comments by latest activity, update stranded feedback batches in place, and represent post-delivery revisions as corrections that survive acknowledgment. Include regression coverage for ordering, pending revisions, and correction delivery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Human Review currently lets reviewers save comments, but editing an existing comment is difficult to discover. If the reviewer notices a mistake after saving, the obvious workaround is to add another comment. That can leave the agent with two conflicting instructions.
Comments are also shown oldest-first, so the feedback a reviewer just added or revised can fall below the visible area of a long review.
This PR makes feedback explicitly editable, orders it by latest activity, and ensures the agent receives the correct revision based on whether the feedback has already been delivered.
Example
A reviewer initially writes:
They then decide it should say:
The edited comment also moves to the top of the feedback rail, keeping the latest activity visible.
Changes
Explicit comment editing
Latest activity first
Safe delivery semantics
Compatibility
Tests
Regression coverage verifies:
93 tests pass on the v0.6.1 base.
git diff --checkalso passes.