-
Notifications
You must be signed in to change notification settings - Fork 779
Implement a server-side cursor to improve performance when fetching large volumes of data. #5797 #8837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GUI-related comments:
- Select 'Use server cursor' from the query tool. Run "select 1" query. Clicking on the Commit button gets the error message " the cursor is closed" and on Rollback "DECLARE "CURSOR:CONN:961921" CURSOR FOR ROLLBACK;" Disable those buttons in server cursor mode.
- Set "Execute with server side cursor?" To true. Select any table and click on View/Edit data. It executes the query, but again commit and rollback buttons get enabled. Now try following:
- Try to close the tab. It will not.
- Pagination shows Page no 1 of 0.
- Click on Next page or Previous page, nothing happens, and the data is lost.
Code-related comments:
- Add this new 'Use server cursor?" preference to the preferences.rst. The screenshot will be updated after Aditya's PR.
- Fix 3 small code smells in sqleditor/init.py
Fixed the issue. I have disabled the buttons right now in View/Edit data but that is debatable, we will discuss that in the review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the preferences screenshot.
No description provided.