Add support of DEPENDS/NO DEPENDS ON EXTENSION for ALTER FUNCTION.#6385 #9170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohitBhati8269
force-pushed
the
GH-6385
branch
from
6be021c to
8ee71ff
Compare
anilsahoo20
reviewed
Sep 23, 2025
| will change to an input text field. | ||
| * Use the drop-down listbox next to *Language* to select the implementation | ||
| language. The default is *sql*. | ||
| * Use the drop-down listbox next to *Depends on extension* to select the extension that this function |
There was a problem hiding this comment.
Make the text same as control label i.e "Depends on extensions"
anilsahoo20
suggested changes
Sep 23, 2025
anilsahoo20
reviewed
Sep 23, 2025
| SET {{ conn|qtIdent(v.name) }}={% if v.name in exclude_quoting %}{{ v.value }}{% else %}{{ v.value|qtLiteral(conn) }}{% endif %}{% endfor %} | ||
| {% endif %} | ||
|
|
||
| {% if data.is_pure_sql %}{{ data.prosrc }} |
There was a problem hiding this comment.
Why is_pure_sql is added in 13_plus?
anilsahoo20
reviewed
Sep 23, 2025
| SET {{ conn|qtIdent(v.name) }}={% if v.name in exclude_quoting %}{{ v.value }}{% else %}{{ v.value|qtLiteral(conn) }}{% endif %}{% endfor -%} | ||
| {% endif %} | ||
|
|
||
| {% if data.is_pure_sql %}{{ data.prosrc }} |
There was a problem hiding this comment.
Why is_pure_sql is added in 13_plus?
anilsahoo20
reviewed
Sep 23, 2025
| }, | ||
| { | ||
| },{ | ||
| id: 'dependsonextensions', |
There was a problem hiding this comment.
Add min_version=130000 as this is available from PGv13
anilsahoo20
reviewed
Sep 23, 2025
| ALTER FUNCTION {{ conn|qtIdent(data.pronamespace, data.name) }}({{data.func_args_without}}) | ||
| OWNER TO {{ conn|qtIdent(data.funcowner) }}; | ||
| {% endif -%} | ||
|
|
There was a problem hiding this comment.
Remove the default folder changes from pg and ppas folder.
anilsahoo20
reviewed
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.