[pgadmin4/pgadmin4-helm] Typo indentation fix for extraEnvVars field, serverDefinitions preserved tpl. README.md typo fix, increased resources #9255
+35
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorenP1
changed the title
KorenP1
force-pushed
the
master
branch
2 times, most recently
from
0b3a8ab to
6b31a33
Compare
KorenP1
changed the title
KorenP1
changed the title
|
Hi @KorenP1, Can the version in the Chart.yaml file be automatically derived from the version.py file instead of being manually hardcoded? |
|
Hi @khushboovashi If you have some kind of script to upload the release it can be changed within the script. Another option if you dont want to maintain helm versions through git, you can insert there some no meaning version for example 1.0.0 and only while releasing process, change it and push without commiting to git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a typo in the indentation of extraEnvVars field
14 -> 12
Now preserving tpl integers and booleans in the serverDefinitions
Typo fix in the README.md, persistence.enabled supposed to be true
Increased default resources
Please repush after merging.
Thanks. Koren.