- 
                Notifications
    
You must be signed in to change notification settings  - Fork 307
 
          feat: add parameter pg_fs_wal (G) to changing pg_wal dir
          #530
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            waitingsong
  wants to merge
  2
  commits into
  pgsty:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
waitingsong:pg_fs_wal
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    3c21019    to
    d820dcd      
    Compare
  
    pg_fs_wal (G|C) to changing pg_wal dirpg_fs_wal (G) to changing pg_wal dir
      de2d0ff    to
    2354546      
    Compare
  
    pg_fs_wal (G) to changing pg_wal dirpg_fs_wal (G) to changing pg_wal dir
      pg_fs_wal (G) to changing pg_wal dirpg_fs_wal (G) to changing pg_wal dir
      1db0301    to
    723bc4f      
    Compare
  
    pg_fs_wal (G) to changing pg_wal dirpg_fs_wal (G) to changing pg_wal dir
      1cae2b0    to
    8ec46f2      
    Compare
  
    pg_fs_wal (G) to changing pg_wal dirpg_fs_wal (G) to changing pg_wal dir
      pg_fs_wal (G) to changing pg_wal dirpg_fs_wal (G) to changing pg_wal dir
      | 
           this one is quite big, may take some time to validate  | 
    
pg_fs_wal (G) to changing pg_wal dirpg_fs_wal (G) to changing pg_wal dir
      - check_pg_ready - is_patroni_paused - start postgres - start and stop postgres gracefully - patroni pause|resume gracefully
new pg_wal style is `<pg_fs_wal>/<pg_cluster>-<pg_version>/pg_wal` when pg_fs_wal defined pg_fs_wal validatiton: pg_fs_wal must start with '/' and not contain spaces modify pg_wal of current pg_cluster: 1. edit and save pigsty.yml by setting the global `pg_wal` 2. run command `./pgsql.yml -l <cls> -t pg_wal` tested scenarios: - `pig sty install` - pg_fs_wal undefined - pg_fs_wal defined - `bin/pgsql-add pg-a` - pg_fs_wal undefined - pg_fs_wal defined - `./pgsql.yml -t pg_wal` - set pg_fs_wal=/wal - set pg_fs_wal=/wal2 (from /wal) - remove pg_fs_wal (from /wal2) - multiple call `./pgsql.yml -t pg_wal` - keep pg_fs_wal undefined or blank - keep pg_fs_wal=/wal `pg-backup full` will be executed automatically if pg_fs_wal changed and apply this settings: - full installation with valid pg_fs_wal (no backup operation if pg_fs_wal undefined or blank) - pg_fs_wal changed after installation - undefined or empty to `/wal` - `/wal` to `/wal2` - `/wal2` to undefined or empty
cc69e58    to
    fae7528      
    Compare
  
    d351d04    to
    9690822      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
new pg_wal style is
<pg_fs_wal>/<pg_cluster>-<pg_version>/pg_walwhen pg_fs_wal definedpg_fs_wal validatiton: pg_fs_wal must start with '/' and not contain spaces
modify pg_wal of current pg_cluster:
pg_wal./pgsql.yml - <cls> -t pg_waltested scenarios:
pig sty installbin/pgsql-add <pg_cluster>bin/pgsql-add <pg_cluster> <ip>./pgsql.yml -t pg_walafter full installation./pgsql.yml -t pg_walpg-backup fullwill be executed automatically if pg_fs_wal changed and apply this settings:/wal/walto/wal2/wal2to undefined or empty