[llrs-roche]

Pull Request

Fixes #361

[github-actions]

Unit Tests Summary

  1 files   17 suites   15s ⏱️
184 tests 155 ✅ 29 💤 0 ❌
360 runs  329 ✅ 31 💤 0 ❌

Results for commit dd2a4b2.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
draggable_buckets	💚	$9.97$	$-2.46$	$0$	$0$	$0$	$0$
plot_with_settings	💚	$3.18$	$-1.30$	$0$	$0$	$0$	$0$
plot_with_settings_ui	💚	$60.75$	$-14.97$	$0$	$0$	$0$	$0$
table_with_settings	💚	$11.75$	$-4.15$	$0$	$0$	$0$	$0$
table_with_settings_ui	💚	$37.39$	$-7.48$	$0$	$0$	$0$	$0$
verbatim_popup_ui	💚	$7.87$	$-1.25$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
draggable_buckets	💚	$4.32$	$-1.36$	e2e_teal.widgets_draggable_buckets_initializes_without_input
plot_with_settings_ui	💚	$4.66$	$-1.12$	e2e_teal.widgets_plot_with_settings_buttons_have_proper_FA_icons_and_two_of_them_are_dropdowns
plot_with_settings_ui	💚	$4.48$	$-1.05$	e2e_teal.widgets_plot_with_settings_clicking_download_download_button_downloads_image_in_a_specified_format
plot_with_settings_ui	💚	$5.38$	$-1.08$	e2e_teal.widgets_plot_with_settings_expanded_image_can_be_downloaded
plot_with_settings_ui	💚	$9.71$	$-2.90$	e2e_teal.widgets_plot_with_settings_expanded_image_can_be_resized
plot_with_settings_ui	💚	$3.64$	$-1.15$	e2e_teal.widgets_plot_with_settings_initializes_with_a_plot_and_the_settings_buttons
plot_with_settings_ui	💚	$4.32$	$-1.19$	e2e_teal.widgets_plot_with_settings_it_is_possible_to_set_height_and_width_for_the_plot_on_the_third_button_dropdown_menu_without_errors
plot_with_settings_ui	💚	$7.00$	$-1.10$	e2e_teal.widgets_plot_with_settings_main_image_can_be_resized
plot_with_settings_ui	💚	$6.26$	$-1.12$	e2e_teal.widgets_plot_with_settings_scrollbar_appears_when_image_is_resized
plot_with_settings_ui	💚	$4.93$	$-1.18$	e2e_teal.widgets_plot_with_settings_the_click_on_the_download_button_in_expand_modal_opens_a_download_dropdown
plot_with_settings_ui	💚	$5.51$	$-1.94$	e2e_teal.widgets_plot_with_settings_the_click_on_the_expand_button_opens_an_overlay_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
plot_with_settings_ui	💚	$4.83$	$-1.13$	e2e_teal.widgets_plot_with_settings_the_click_on_the_resize_button_opens_a_dropdown_menu_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
table_with_settings	💚	$3.90$	$-1.22$	type_download_srv_table_downloading_tbl_split_output_types
table_with_settings_ui	💚	$4.66$	$-1.05$	e2e_teal.widgets_table_with_settings_the_click_on_the_download_button_opens_a_download_menu_with_file_type_file_name_and_download_button

Results for commit e54dcd2

♻️ This comment has been updated with latest results.

[llrs-roche]

I see a test failing and I opened an issue for it #363

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      12  86.21%   116-121, 151-156
R/get_dt_rows.R                  13       0  100.00%
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255      79  69.02%   190, 315-389, 402-409, 411-416, 434, 436, 501, 583-596
R/panel_group.R                  39       8  79.49%   72-79
R/plot_with_settings.R          312      16  94.87%   301-307, 329, 366, 375-376, 392, 583-584, 586, 588
R/standard_layout.R              52       4  92.31%   90-93
R/table_with_settings.R         258       6  97.67%   198, 424-428
R/utils.R                        35       0  100.00%
R/verbatim_popup.R              104      35  66.35%   112-113, 115, 123-154
R/white_small_well.R              7       0  100.00%
TOTAL                          1254     180  85.65%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: dd2a4b2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[osenan]

There is one small change/question.
Besides from that, is in line with the other repos, so it is good to approve.