[wangben718]

Pull Request

Proposed Structure of AGENTS.md:

• Header + role — one line on what the package is, its boundaries ("does NOT build apps / define modules / touch teal_data"), and a pointer to teal's AGENTS.md for ecosystem-wide rules.
• Commands — exact, non-guessable invocations: load/document/test/check, single-test, lint/style, and pre-commit.
• Gotchas & conventions — the heart: traps and guardrails with file references, including the silent TESTING_DEPTH test-skipping, base/grid plots being first-class (unlike the ecosystem "prefer ggplot2" rule), the webshot2 PDF-export dependency, and "add an S3 method, don't branch" for new table types.
• Widget shape — the one non-derivable invariant: the _ui/_srv suffix convention (vs. teal's ui_/srv_ prefix).

Fixes #360

[github-actions]

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

[github-actions]

Unit Tests Summary

  1 files   17 suites   2m 12s ⏱️
182 tests 181 ✅ 0 💤 0 ❌ 1 🔥
424 runs  423 ✅ 0 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 92b7b24.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
plot_with_settings_ui	💔	$53.62$	$+3.51$	$0$	$0$	$0$	$0$
table_with_settings	💚	$13.73$	$-4.03$	$-1$	$0$	$0$	$+1$
table_with_settings_ui	💔	$33.80$	$+2.07$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
table_with_settings	💚	$3.04$	$-1.74$	type_download_srv_table_downloading_gtsummary_output_types
table_with_settings	💚	$5.29$	$-1.59$	type_download_srv_table_downloading_tbl_split_output_types

Results for commit 549d002

♻️ This comment has been updated with latest results.

[llrs-roche]

Let's put it on hold until we finish insightsengineering/nestdevs-tasks#121

[wangben718]

I have read the CLA Document and I hereby sign the CLA

[llrs-roche]

Hi, @wangben718 Even if it is not merged yet, could you follow the PR as in pharmaverse/teal.code#298, so that it inherits from a shared file and has a specific section tailored for this package? Try also to make it pass all checks on the CI.
Thanks!

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      12  86.21%   116-121, 151-156
R/get_dt_rows.R                  13       0  100.00%
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255      79  69.02%   190, 315-389, 402-409, 411-416, 434, 436, 501, 583-596
R/panel_group.R                  39       8  79.49%   72-79
R/plot_with_settings.R          310      16  94.84%   301-307, 329, 366, 375-376, 392, 580-581, 583, 585
R/standard_layout.R              52       4  92.31%   90-93
R/table_with_settings.R         259       6  97.68%   204, 429-433
R/utils.R                        19       0  100.00%
R/verbatim_popup.R              104      35  66.35%   112-113, 115, 123-154
R/white_small_well.R              7       0  100.00%
TOTAL                          1237     180  85.45%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  -------
R/table_with_settings.R       +3       0  +0.03%
TOTAL                         +3       0  +0.04%

Results for commit: c28b1ca

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[llrs-roche]

Changes on R/*.R shouldn't be of that depth. Please if any change is needed there make your case with an issue and a different PR.

The content looks okay, it follows the agreed structure. I don't miss anything but at the same time I'm not sure if there are some unwritten rules for the package that I haven't heard of.

[llrs-roche]

The only points left are the formal ones about where the file should be. Thanks!

[wangben718]

Thanks @llrs-roche for the heads-up. I have moved the RMD file to vignettes folder.

[llrs-roche]

Sorry, I missed this previously but there is no CLAUDE.md file on this PR!! Add it before merging please

[wangben718]

Sorry, I missed this previously but there is no CLAUDE.md file on this PR!! Add it before merging please

Here is the CLAUDE.md: https://github.com/insightsengineering/teal.widgets/pull/364/changes#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7