-
Notifications
You must be signed in to change notification settings - Fork 79
Fix typo in conditional jump methods #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
m-demare
wants to merge
41
commits into
pharo-project:pharo-12
Choose a base branch
from
m-demare:typo-jump-if
base: pharo-12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add windows support for non ASCII filenames in basicImageFileExists
Use the correct siginfo_t type for signal handlers. struct __siginfo is not exposed anymore in newer systems
Fix signal handler signature
Prepare release 10.3.4
Co-authored-by: Shengyu Huang <[email protected]>
Remove set cursor C code pharo-project#210
fix PharoWorker value when coming from plist file
log worker mode
Updating SDL2 to 2.32.6 for Windows (x86_64) and MacOS (ARM and Intel)
…size-as-parameter-p10 Set the size of larger indexable object allocated in the young space
Preparing Release 10.3.5
[P10] Fix OBS Build
Fix Issue 982 - Pharo 10 branch
…esocket after the aioPoll is done. This issue only affect Windows Servers as they behave different than Unixes and Windows non-Servers
…onep/pharo-vm into fix-missing-accept-on-socket
…on-socket Fix missing accept on socket
… windows with the rules of alignments the structure size changes and we have crashes in the VM.
…dows fixing-build-in-windows
PalumboN
previously approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceeee 🤓
This should not go to pharo-12
?
No idea, should it? :p |
Ouf, I changed the base and stuff happened, does this need a rebase maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were typos in the following methods:
jumplfTrueBy
->jumpIfTrueBy
jumplfFalseBy
->jumpIfFalseBy