Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed IRMethod (that got renamed to OCIRMethod) #17744

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

JanBliznicenko
Copy link
Contributor

Removed IRMethod (that got renamed to OCIRMethod), fixes #17722 (cleanup)

@Ducasse
Copy link
Member

Ducasse commented Feb 2, 2025

In fact I guess that I forgot to declare aliases for IR classes that I renamed.
Following:
May be this is ok too :)

postload: loader package: packageSpec
	 "Ignore pre and post loads if already executed"

	 Initialized = true ifTrue: [ ^ self ].

	 "This should be removed in Pharo 14."
	 OCNode deprecatedAliases: { #RBNode. #ASTNode }.
	 OCProgramNode deprecatedAliases: { #RBProgramNode. #ASTProgramNode }.
	 OCValueNode deprecatedAliases: { #RBValueNode. #ASTValueNode }.
	 OCLiteralNode deprecatedAliases: { #RBLiteralNode. #ASTLiteralNode }.
	 OCLiteralArrayNode deprecatedAliases:
		 { #RBLiteralArrayNode. #ASTLiteralArrayNode }.
	 OCLiteralValueNode deprecatedAliases:
		 { #RBLiteralValueNode. #ASTLiteralValueNode }.
	 OCArrayNode deprecatedAliases: { #RBArrayNode. #ASTArrayNode }.
	 OCAssignmentNode deprecatedAliases: {
			 #RBAssignmentNode.
			 #ASTAssignmentNode }.
	 OCCascadeNode deprecatedAliases: { #RBCascadeNode. #ASTCascadeNode }.
	 OCReturnNode deprecatedAliases: { #RBReturnNode. #ASTReturnNode }.
	 OCVariableNode deprecatedAliases:
		 { #RBVariableNode. #ASTVariableNode }.
	 OCCommentNode deprecatedAliases: { #RBComment. #ASTComment }.
	 OCBlockNode deprecatedAliases: { #RBBlockNode. #ASTBlockNode }.
	 OCMessageNode deprecatedAliases: { #RBMessageNode. #ASTMessageNode }.
	 OCSelectorNode deprecatedAliases:
		 { #RBSelectorNode. #ASTSelectorNode }.
	 OCPragmaNode deprecatedAliases: { #RBPragmaNode. #ASTPragmaNode }.
	 OCSequenceNode deprecatedAliases:
		 { #RBSequenceNode. #ASTSequenceNode }.
	 OCAnnotationMarkNode deprecatedAliases:
		 { #RBAnnotationMarkNode. #ASTAnnotationMarkNode }.
	 OCMethodNode deprecatedAliases: { #RBMethodNode. #ASTMethodNode }.
	 OCDoItMethodNode deprecatedAliases:
		 { #RBDoItMethodNode. #ASTDoItMethodNode }.
	 OCEnglobingErrorNode deprecatedAliases:
		 { #RBEnglobingErrorNode. #ASTEnglobingErrorNode }.
	 OCArrayErrorNode deprecatedAliases:
		 { #RBArrayErrorNode. #ASTArrayErrorNode }.
	 OCUnfinishedStatementErrorNode deprecatedAliases:
		 { #RBUnfinishedStatementErrorNode. #ASTUnfinishedStatementErrorNode }.
	 OCLiteralByteArrayErrorNode deprecatedAliases:
		 { #RBLiteralByteArrayErrorNode. #ASTLiteralByteArrayErrorNode }.
	 OCPragmaErrorNode deprecatedAliases:
		 { #RBPragmaErrorNode. #ASTPragmaErrorNode }.
	 OCLiteralArrayErrorNode deprecatedAliases:
		 { #RBLiteralArrayErrorNode. #ASTLiteralArrayErrorNode }.
	 OCParenthesesErrorNode deprecatedAliases:
		 { #RBParenthesesErrorNode. #ASTParenthesesErrorNode }.
	 OCAssignmentErrorNode deprecatedAliases:
		 { #RBAssignmentErrorNode. #ASTAssignmentErrorNode }.
	 OCBlockErrorNode deprecatedAliases:
		 { #RBBlockErrorNode. #ASTBlockErrorNode }.
	 OCTemporariesErrorNode deprecatedAliases:
		 { #RBTemporariesErrorNode. #ASTTemporariesErrorNode }.
	 OCInvalidCascadeErrorNode deprecatedAliases:
		 { #RBInvalidCascadeErrorNode. #ASTInvalidCascadeErrorNode }.
	 OCParseErrorNode deprecatedAliases:
		 { #RBParseErrorNode. #ASTParseErrorNode }.

	 OCAbstractFormatter deprecatedAliases:
		 { #RBAbstractFormatter. #ASTAbstractFormatter }.
	 OCSimpleFormatter deprecatedAliases:
		 { #RBSimpleFormatter. #ASTSimpleFormatter }.

	 OCParseTreeSearcher deprecatedAliases:
		 { #RBParseTreeSearcher. #ASTParseTreeSearcher }.
	 OCParseTreeRule deprecatedAliases:
		 { #RBParseTreeRule. #ASTParseTreeRule }.
	 OCReplaceRule deprecatedAliases: { #RBReplaceRule. #ASTReplaceRule }.
	 OCSearchRule deprecatedAliases: { #RBSearchRule. #ASTSearchRule }.
	 OCBlockReplaceRule deprecatedAliases:
		 { #RBBlockReplaceRule. #ASTBlockReplaceRule }.
	 OCParseTreeRewriter deprecatedAliases:
		 { #RBParseTreeRewriter. #ASTParseTreeRewriter }.
	 OCStringReplacement deprecatedAliases:
		 { #RBStringReplacement. #ASTStringReplacement }.
	 OCStringReplaceRule deprecatedAliases:
		 { #RBStringReplaceRule. #ASTStringReplaceRule }.

	 OCReadBeforeWrittenTester deprecatedAliases:
		 { #RBReadBeforeWrittenTester. #ASTReadBeforeWrittenTester }.
	 OCProgramNodeVisitor deprecatedAliases:
		 { #RBProgramNodeVisitor. #ASTProgramNodeVisitor }.
	 OCReturnNodeAdderVisitor deprecatedAliases:
		 { #RBReturnNodeAdderVisitor. #ASTReturnNodeAdderVisitor }.
	 OCParseErrorNodeVisitor deprecatedAliases:
		 { #RBParseErrorNodeVisitor. #ASTParseErrorNodeVisitor }.
	 OCCommentNodeVisitor deprecatedAliases:
		 { #RBCommentNodeVisitor. #ASTCommentNodeVisitor }.
	 OCGenericNodeVisitor deprecatedAliases:
		 { #RBGenericNodeVisitor. #ASTGenericNodeVisitor }.
	 OCDumpVisitor deprecatedAliases: { #RBDumpVisitor. #ASTDumpVisitor }.
	 OCAbstractBlockVisitor deprecatedAliases:
		 { #RBAbstractBlockVisitor. #ASTAbstractBlockVisitor }.

	 OCErrorNotice deprecatedAliases: { #RBErrorNotice. #ASTErrorNotice }.
	 OCWarningNotice deprecatedAliases:
		 { #RBWarningNotice. #ASTWarningNotice }.
	 OCSyntaxErrorNotice deprecatedAliases:
		 { #RBSyntaxErrorNotice. #ASTSyntaxErrorNotice }.
	 OCNotice deprecatedAliases: { #RBNotice. #ASTNotice }.

	 OCCommentToken deprecatedAliases:
		 { #RBCommentToken. #ASTCommentToken }.
	 OCLiteralToken deprecatedAliases:
		 { #RBLiteralToken. #ASTLiteralToken }.
	 OCSpecialCharacterToken deprecatedAliases:
		 { #RBSpecialCharacterToken. #ASTSpecialCharacterToken }.
	 OCIdentifierToken deprecatedAliases:
		 { #RBIdentifierToken. #ASTIdentifierToken }.
	 OCNumberLiteralToken deprecatedAliases:
		 { #RBNumberLiteralToken. #ASTNumberLiteralToken }.
	 OCToken deprecatedAliases: { #RBToken. #ASTToken }.
	 OCBinarySelectorToken deprecatedAliases:
		 { #RBBinarySelectorToken. #ASTBinarySelectorToken }.
	 OCKeywordToken deprecatedAliases:
		 { #RBKeywordToken. #ASTKeywordToken }.
	 OCAssignmentToken deprecatedAliases:
		 { #RBAssignmentToken. #ASTAssignmentToken }.
	 OCErrorToken deprecatedAliases: { #RBErrorToken. #ASTErrorToken }.
	 OCValueToken deprecatedAliases: { #RBValueToken. #ASTValueToken }.
	 OCEOFToken deprecatedAliases: { #RBEOFToken. #ASTEOFToken }.
	 OCLiteralArrayToken deprecatedAliases:
		 { #RBLiteralArrayToken. #ASTLiteralArrayToken }.
	 OCPatternBlockToken deprecatedAliases:
		 { #RBPatternBlockToken. #ASTPatternBlockToken }.

	 OCPatternMessageNode deprecatedAliases:
		 { #RBPatternMessageNode. #ASTPatternMessageNode }.
	 OCPatternBlockNode deprecatedAliases:
		 { #RBPatternBlockNode. #ASTPatternBlockNode }.
	 OCPatternWrapperBlockNode deprecatedAliases:
		 { #RBPatternWrapperBlockNode. #ASTPatternWrapperBlockNode }.
	 OCPatternMethodNode deprecatedAliases:
		 { #RBPatternMethodNode. #ASTPatternMethodNode }.
	 OCPatternVariableNode deprecatedAliases:
		 { #RBPatternVariableNode. #ASTPatternVariableNode }.
	 OCPatternPragmaNode deprecatedAliases:
		 { #RBPatternPragmaNode. #ASTPatternPragmaNode }.

	OCDoItVariable deprecatedAliases: { #DoItVariable }.

	 CompletionSorter register.
	 RubSmalltalkEditor completionEngineClass: CompletionEngine.

	 Initialized := true

@JanBliznicenko
Copy link
Contributor Author

Yes, @Ducasse, just a moment ago, I have actually created an issue (#17745) for the fact that there is not deprecation used for OpalCompiler-Core like the one you linked for AST-Core :)

Also, I have no idea what is the failed test telling us

@Ducasse
Copy link
Member

Ducasse commented Feb 2, 2025

Failing tests are unrelated.
In fact I tried to deprecate classes the old (eg by subclassing the new class with an old empty class) but this does not work
for Parser because the parser is creating instance of the new class (superclass) and extensions were defined on the old :)
So the deprecatedAliases: approach is much better.
So I will integrate this PR and we can do another one with the aliases.

@Ducasse Ducasse merged commit 117e72c into pharo-project:Pharo13 Feb 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IRMethod should be removed
2 participants