Skip to content

feat: add meta proto service for service discovery#543

Open
oguzcan oguz (oguzcanoguz) wants to merge 74 commits intomainfrom
feature/proto_service_discovery
Open

feat: add meta proto service for service discovery#543
oguzcan oguz (oguzcanoguz) wants to merge 74 commits intomainfrom
feature/proto_service_discovery

Conversation

@oguzcanoguz
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.05s
✅ CPP clang-format 1027 3 0 6.66s
✅ DOCKERFILE hadolint 2 0 0.16s
✅ JSON jsonlint 7 0 0.19s
✅ JSON prettier 7 0 0 0.75s
⚠️ MARKDOWN markdownlint 6 0 4 1.48s
⚠️ MARKDOWN markdown-link-check 6 1 3060.51s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.2s
✅ REPOSITORY checkov yes no 18.83s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY grype yes no 10.36s
✅ REPOSITORY ls-lint yes no 0.06s
✅ REPOSITORY secretlint yes no 6.14s
✅ REPOSITORY trivy yes no 5.64s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 3.48s
⚠️ SPELL lychee 140 186 5.75s
⚠️ YAML prettier 22 1 1 0.84s
✅ YAML v8r 22 0 9.08s
✅ YAML yamllint 22 0 0.44s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sonarqubecloud
Copy link

@richardapeters Richard Peters (richardapeters) changed the title feat: Add meta proto service for service discovery feat: add meta proto service for service discovery Feb 21, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz oguzcan oguz (oguzcanoguz) marked this pull request as ready for review April 17, 2025 11:31
Comment on lines +22 to +26
class ServiceIdAccess
{
public:
static uint32_t GetId(const ServiceId& serviceId);
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone can use ServiceIdAccess, then you might as well just add GetId() to ServiceId instead of adding this class

Comment on lines -79 to +78
static const uint32_t serviceId = 1;
static constexpr uint32_t defaultServiceId = 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serviceId has been moved into services::Service. But do you need defaultServiceId here?

Comment on lines +163 to +169
for (const auto& service : newServiceList)
{
if (service >= searchBegin && service <= searchEnd)
{
filteredServices.push_back(service);
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (const auto& service : newServiceList)
{
if (service >= searchBegin && service <= searchEnd)
{
filteredServices.push_back(service);
}
}
for (const auto& service : newServiceList)
if (service >= searchBegin && service <= searchEnd)
filteredServices.push_back(service);

void DataReceived() override;
~ConsoleClientConnection();

// ConnectionObserver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ConnectionObserver
// Implementation of ConnectionObserver

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants