feat: add meta proto service for service discovery#543
Open
oguzcan oguz (oguzcanoguz) wants to merge 74 commits intomainfrom
Open
feat: add meta proto service for service discovery#543oguzcan oguz (oguzcanoguz) wants to merge 74 commits intomainfrom
oguzcan oguz (oguzcanoguz) wants to merge 74 commits intomainfrom
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Contributor
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0.05s | |
| ✅ CPP | clang-format | 1027 | 3 | 0 | 6.66s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0.16s | |
| ✅ JSON | jsonlint | 7 | 0 | 0.19s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0.75s |
| markdownlint | 6 | 0 | 4 | 1.48s | |
| markdown-link-check | 6 | 1 | 3060.51s | ||
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0.2s |
| ✅ REPOSITORY | checkov | yes | no | 18.83s | |
| ✅ REPOSITORY | git_diff | yes | no | 0.05s | |
| ✅ REPOSITORY | grype | yes | no | 10.36s | |
| ✅ REPOSITORY | ls-lint | yes | no | 0.06s | |
| ✅ REPOSITORY | secretlint | yes | no | 6.14s | |
| ✅ REPOSITORY | trivy | yes | no | 5.64s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | 0.08s | |
| ✅ REPOSITORY | trufflehog | yes | no | 3.48s | |
| lychee | 140 | 186 | 5.75s | ||
| prettier | 22 | 1 | 1 | 0.84s | |
| ✅ YAML | v8r | 22 | 0 | 9.08s | |
| ✅ YAML | yamllint | 22 | 0 | 0.44s |
See detailed report in MegaLinter reports
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines
+22
to
+26
| class ServiceIdAccess | ||
| { | ||
| public: | ||
| static uint32_t GetId(const ServiceId& serviceId); | ||
| }; |
Collaborator
There was a problem hiding this comment.
If anyone can use ServiceIdAccess, then you might as well just add GetId() to ServiceId instead of adding this class
Comment on lines
-79
to
+78
| static const uint32_t serviceId = 1; | ||
| static constexpr uint32_t defaultServiceId = 1; |
Collaborator
There was a problem hiding this comment.
serviceId has been moved into services::Service. But do you need defaultServiceId here?
Comment on lines
+163
to
+169
| for (const auto& service : newServiceList) | ||
| { | ||
| if (service >= searchBegin && service <= searchEnd) | ||
| { | ||
| filteredServices.push_back(service); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| for (const auto& service : newServiceList) | |
| { | |
| if (service >= searchBegin && service <= searchEnd) | |
| { | |
| filteredServices.push_back(service); | |
| } | |
| } | |
| for (const auto& service : newServiceList) | |
| if (service >= searchBegin && service <= searchEnd) | |
| filteredServices.push_back(service); |
| void DataReceived() override; | ||
| ~ConsoleClientConnection(); | ||
|
|
||
| // ConnectionObserver |
Collaborator
There was a problem hiding this comment.
Suggested change
| // ConnectionObserver | |
| // Implementation of ConnectionObserver |
Richard Peters (richardapeters)
approved these changes
May 16, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.