Skip to content

#109 Removing domain property from policy #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

#109 Removing domain property from policy #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b46af0
#109 Removing domain property from policy.
jzonthemtn Mar 24, 2025
9b2ada1
Merge branch 'main' into 109-remove-domain
jzonthemtn Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions phileas-core/src/main/java/ai/philterd/phileas/services/PhileasFilterService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,8 @@
package ai.philterd.phileas.services;

import ai.philterd.phileas.model.configuration.PhileasConfiguration;
import ai.philterd.phileas.model.domain.Domain;
import ai.philterd.phileas.model.domain.HealthDomain;
import ai.philterd.phileas.model.domain.LegalDomain;
import ai.philterd.phileas.model.enums.FilterType;
import ai.philterd.phileas.model.enums.MimeType;
import ai.philterd.phileas.model.services.Classification;
import ai.philterd.phileas.model.filter.Filter;
import ai.philterd.phileas.model.objects.Explanation;
import ai.philterd.phileas.model.objects.PdfRedactionOptions;
Expand All @@ -35,6 +31,7 @@
import ai.philterd.phileas.model.serializers.PlaceholderDeserializer;
import ai.philterd.phileas.model.services.AlertService;
import ai.philterd.phileas.model.services.CacheService;
import ai.philterd.phileas.model.services.Classification;
import ai.philterd.phileas.model.services.DocumentProcessor;
import ai.philterd.phileas.model.services.FilterService;
import ai.philterd.phileas.model.services.MetricsService;
Expand Down Expand Up @@ -145,23 +142,6 @@ public FilterResponse filter(final Policy policy, final String context, String d
// Initialize potential attributes that are associated with the input text.
final Map<String, String> attributes = new HashMap<>();

// Load default values based on the domain.
if(StringUtils.equalsIgnoreCase(Domain.DOMAIN_LEGAL, policy.getDomain())) {

// PHL-209: Implement legal domain.
policy.getIgnored().add(LegalDomain.getInstance().getIgnored());

// TODO: #109 Add filters.

} else if(StringUtils.equalsIgnoreCase(Domain.DOMAIN_HEALTH, policy.getDomain())) {

// PHL-210: Implement health domain.
policy.getIgnored().add(HealthDomain.getInstance().getIgnored());

// TODO: #110 Add filters.

}

final List<Filter> filters = filterPolicyLoader.getFiltersForPolicy(policy, filterCache);
final List<PostFilter> postFilters = getPostFiltersForPolicy(policy);

Expand Down
13 changes: 0 additions & 13 deletions phileas-model/src/main/java/ai/philterd/phileas/model/policy/Policy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ public class Policy {
@Expose
private FPE fpe;

@SerializedName("domain")
@Expose
private String domain;

@SerializedName("identifiers")
@Expose
private Identifiers identifiers = new Identifiers();
Expand All @@ -70,7 +66,6 @@ public boolean equals(Object o) {
public int hashCode() {
return new HashCodeBuilder(17, 37).
append(name).
append(domain).
append(crypto).
append(identifiers).
append(ignored).
Expand Down Expand Up @@ -127,14 +122,6 @@ public void setConfig(Config config) {
this.config = config;
}

public String getDomain() {
return domain;
}

public void setDomain(String domain) {
this.domain = domain;
}

public Graphical getGraphical() {
return graphical;
}
Expand Down