Skip to content

Fix sonar issues #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phleyas wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix sonar issues #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4940c3
add husky
phleyas Feb 28, 2026
aa8cca6
add lint-staged
phleyas Feb 28, 2026
b753245
fix sonar issues
phleyas Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
build-and-test:
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@v4

- uses: docker/setup-buildx-action@v3
Expand Down
1 change: 1 addition & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
npx lint-staged
3 changes: 3 additions & 0 deletions .lintstagedrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"**/*": "npx prettier --write --ignore-unknown"
}
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Stage 1: Build the Angular Application
# =========================================
ARG NODE_VERSION=24-alpine
ARG NGINX_VERSION=alpine3.21
ARG NGINX_VERSION=1.28.0-alpine3.21


# Use a lightweight Node.js image for building (customizable via ARG)
Expand Down
2 changes: 0 additions & 2 deletions Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ COPY package.json package-lock.json ./
# Install dependencies using npm with caching to speed up subsequent builds
RUN --mount=type=cache,target=/root/.npm npm ci

# Create a safe npm cache inside the container
RUN npm ci
# Copy all application source files into the container
COPY . .

Expand Down
2 changes: 0 additions & 2 deletions apps/shell-mobile/src/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
* https://ionicframework.com/docs/theming/dark-mode
*/

/* @import url('@ionic/angular/css/palettes/dark.always.css'); */
/* @import url('@ionic/angular/css/palettes/dark.class.css'); */
@import url('@ionic/angular/css/palettes/dark.system.css');
.apexcharts-legend-text {
color: var(--ion-text-color) !important;
Expand Down
243 changes: 0 additions & 243 deletions apps/shell-mobile/src/theme/variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,243 +0,0 @@
// // Ionic Variables and Theming. For more info, please see:
// // http://ionicframework.com/docs/theming/

// /** Ionic CSS Variables **/
// :root {
// /** primary **/
// --ion-color-primary: #3880ff;
// --ion-color-primary-rgb: 56, 128, 255;
// --ion-color-primary-contrast: #ffffff;
// --ion-color-primary-contrast-rgb: 255, 255, 255;
// --ion-color-primary-shade: #3171e0;
// --ion-color-primary-tint: #4c8dff;

// /** secondary **/
// --ion-color-secondary: #3dc2ff;
// --ion-color-secondary-rgb: 61, 194, 255;
// --ion-color-secondary-contrast: #ffffff;
// --ion-color-secondary-contrast-rgb: 255, 255, 255;
// --ion-color-secondary-shade: #36abe0;
// --ion-color-secondary-tint: #50c8ff;

// /** tertiary **/
// --ion-color-tertiary: #5260ff;
// --ion-color-tertiary-rgb: 82, 96, 255;
// --ion-color-tertiary-contrast: #ffffff;
// --ion-color-tertiary-contrast-rgb: 255, 255, 255;
// --ion-color-tertiary-shade: #4854e0;
// --ion-color-tertiary-tint: #6370ff;

// /** success **/
// --ion-color-success: #2dd36f;
// --ion-color-success-rgb: 45, 211, 111;
// --ion-color-success-contrast: #ffffff;
// --ion-color-success-contrast-rgb: 255, 255, 255;
// --ion-color-success-shade: #28ba62;
// --ion-color-success-tint: #42d77d;

// /** warning **/
// --ion-color-warning: #ffc409;
// --ion-color-warning-rgb: 255, 196, 9;
// --ion-color-warning-contrast: #000000;
// --ion-color-warning-contrast-rgb: 0, 0, 0;
// --ion-color-warning-shade: #e0ac08;
// --ion-color-warning-tint: #ffca22;

// /** danger **/
// --ion-color-danger: #eb445a;
// --ion-color-danger-rgb: 235, 68, 90;
// --ion-color-danger-contrast: #ffffff;
// --ion-color-danger-contrast-rgb: 255, 255, 255;
// --ion-color-danger-shade: #cf3c4f;
// --ion-color-danger-tint: #ed576b;

// /** dark **/
// --ion-color-dark: #222428;
// --ion-color-dark-rgb: 34, 36, 40;
// --ion-color-dark-contrast: #ffffff;
// --ion-color-dark-contrast-rgb: 255, 255, 255;
// --ion-color-dark-shade: #1e2023;
// --ion-color-dark-tint: #383a3e;

// /** medium **/
// --ion-color-medium: #92949c;
// --ion-color-medium-rgb: 146, 148, 156;
// --ion-color-medium-contrast: #ffffff;
// --ion-color-medium-contrast-rgb: 255, 255, 255;
// --ion-color-medium-shade: #808289;
// --ion-color-medium-tint: #9d9fa6;

// /** light **/
// --ion-color-light: #f4f5f8;
// --ion-color-light-rgb: 244, 245, 248;
// --ion-color-light-contrast: #000000;
// --ion-color-light-contrast-rgb: 0, 0, 0;
// --ion-color-light-shade: #d7d8da;
// --ion-color-light-tint: #f5f6f9;
// }

// @media (prefers-color-scheme: dark) {
// /*
// * Dark Colors
// * -------------------------------------------
// */

// body {
// --ion-color-primary: #428cff;
// --ion-color-primary-rgb: 66,140,255;
// --ion-color-primary-contrast: #ffffff;
// --ion-color-primary-contrast-rgb: 255,255,255;
// --ion-color-primary-shade: #3a7be0;
// --ion-color-primary-tint: #5598ff;

// --ion-color-secondary: #50c8ff;
// --ion-color-secondary-rgb: 80,200,255;
// --ion-color-secondary-contrast: #ffffff;
// --ion-color-secondary-contrast-rgb: 255,255,255;
// --ion-color-secondary-shade: #46b0e0;
// --ion-color-secondary-tint: #62ceff;

// --ion-color-tertiary: #6a64ff;
// --ion-color-tertiary-rgb: 106,100,255;
// --ion-color-tertiary-contrast: #ffffff;
// --ion-color-tertiary-contrast-rgb: 255,255,255;
// --ion-color-tertiary-shade: #5d58e0;
// --ion-color-tertiary-tint: #7974ff;

// --ion-color-success: #2fdf75;
// --ion-color-success-rgb: 47,223,117;
// --ion-color-success-contrast: #000000;
// --ion-color-success-contrast-rgb: 0,0,0;
// --ion-color-success-shade: #29c467;
// --ion-color-success-tint: #44e283;

// --ion-color-warning: #ffd534;
// --ion-color-warning-rgb: 255,213,52;
// --ion-color-warning-contrast: #000000;
// --ion-color-warning-contrast-rgb: 0,0,0;
// --ion-color-warning-shade: #e0bb2e;
// --ion-color-warning-tint: #ffd948;

// --ion-color-danger: #ff4961;
// --ion-color-danger-rgb: 255,73,97;
// --ion-color-danger-contrast: #ffffff;
// --ion-color-danger-contrast-rgb: 255,255,255;
// --ion-color-danger-shade: #e04055;
// --ion-color-danger-tint: #ff5b71;

// --ion-color-dark: #f4f5f8;
// --ion-color-dark-rgb: 244,245,248;
// --ion-color-dark-contrast: #000000;
// --ion-color-dark-contrast-rgb: 0,0,0;
// --ion-color-dark-shade: #d7d8da;
// --ion-color-dark-tint: #f5f6f9;

// --ion-color-medium: #989aa2;
// --ion-color-medium-rgb: 152,154,162;
// --ion-color-medium-contrast: #000000;
// --ion-color-medium-contrast-rgb: 0,0,0;
// --ion-color-medium-shade: #86888f;
// --ion-color-medium-tint: #a2a4ab;

// --ion-color-light: #222428;
// --ion-color-light-rgb: 34,36,40;
// --ion-color-light-contrast: #ffffff;
// --ion-color-light-contrast-rgb: 255,255,255;
// --ion-color-light-shade: #1e2023;
// --ion-color-light-tint: #383a3e;
// }

// /*
// * iOS Dark Theme
// * -------------------------------------------
// */

// .ios body {
// --ion-background-color: #000000;
// --ion-background-color-rgb: 0,0,0;

// --ion-text-color: #ffffff;
// --ion-text-color-rgb: 255,255,255;

// --ion-color-step-50: #0d0d0d;
// --ion-color-step-100: #1a1a1a;
// --ion-color-step-150: #262626;
// --ion-color-step-200: #333333;
// --ion-color-step-250: #404040;
// --ion-color-step-300: #4d4d4d;
// --ion-color-step-350: #595959;
// --ion-color-step-400: #666666;
// --ion-color-step-450: #737373;
// --ion-color-step-500: #808080;
// --ion-color-step-550: #8c8c8c;
// --ion-color-step-600: #999999;
// --ion-color-step-650: #a6a6a6;
// --ion-color-step-700: #b3b3b3;
// --ion-color-step-750: #bfbfbf;
// --ion-color-step-800: #cccccc;
// --ion-color-step-850: #d9d9d9;
// --ion-color-step-900: #e6e6e6;
// --ion-color-step-950: #f2f2f2;

// --ion-item-background: #000000;

// --ion-card-background: #1c1c1d;
// }

// .ios ion-modal {
// --ion-background-color: var(--ion-color-step-100);
// --ion-toolbar-background: var(--ion-color-step-150);
// --ion-toolbar-border-color: var(--ion-color-step-250);
// }

// /*
// * Material Design Dark Theme
// * -------------------------------------------
// */

// .md body {
// --ion-background-color: #121212;
// --ion-background-color-rgb: 18,18,18;

// --ion-text-color: #ffffff;
// --ion-text-color-rgb: 255,255,255;

// --ion-border-color: #222222;

// --ion-color-step-50: #1e1e1e;
// --ion-color-step-100: #2a2a2a;
// --ion-color-step-150: #363636;
// --ion-color-step-200: #414141;
// --ion-color-step-250: #4d4d4d;
// --ion-color-step-300: #595959;
// --ion-color-step-350: #656565;
// --ion-color-step-400: #717171;
// --ion-color-step-450: #7d7d7d;
// --ion-color-step-500: #898989;
// --ion-color-step-550: #949494;
// --ion-color-step-600: #a0a0a0;
// --ion-color-step-650: #acacac;
// --ion-color-step-700: #b8b8b8;
// --ion-color-step-750: #c4c4c4;
// --ion-color-step-800: #d0d0d0;
// --ion-color-step-850: #dbdbdb;
// --ion-color-step-900: #e7e7e7;
// --ion-color-step-950: #f3f3f3;

// --ion-item-background: #1e1e1e;

// --ion-toolbar-background: #1f1f1f;

// --ion-tab-bar-background: #1f1f1f;

// --ion-card-background: #1e1e1e;
// }
// }

// html {
// /*
// * For more information on dynamic font scaling, visit the documentation:
// * https://ionicframework.com/docs/layout/dynamic-font-scaling
// */
// --ion-dynamic-font: var(--ion-default-dynamic-font);
// }
8 changes: 7 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@ export default [
...nx.configs['flat/javascript'],
...angular.configs.tsRecommended,
{
ignores: ['**/dist', '**/vite.config.*.timestamp*', '**/vitest.config.*.timestamp*'],
ignores: [
'**/dist',
'**/vite.config.*.timestamp*',
'**/vitest.config.*.timestamp*',
'apps/shell-mobile/android',
'libs/open-api/src',
],
},
...tseslint.configs.recommended.map(cfg => ({
files: ['**/*.ts', '**/*.tsx'],
Expand Down
20 changes: 10 additions & 10 deletions libs/air-quality/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@
"name": "air-quality",
"version": "0.0.1",
"peerDependencies": {
"@angular/core": "20.3.0",
"@angular/core": "21.0.0",
"@frontend/open-api": "0.0.1",
"@nx/angular": "21.5.2",
"@nx/angular": "22.5.3",
"vite": "6.3.6",
"@analogjs/vite-plugin-angular": "1.21.0",
"@nx/vite": "21.5.2",
"@analogjs/vite-plugin-angular": "2.3.0",
"@nx/vite": "22.5.3",
"rxjs": "7.8.0",
"@frontend/shared": "0.0.1",
"@angular/forms": "20.3.0",
"@angular/forms": "21.0.0",
"apexcharts": "5.3.5",
"@angular/common": "20.3.0",
"@angular/router": "20.3.0",
"@ngrx/store": "20.0.1",
"@ngrx/effects": "20.0.1",
"@ngrx/operators": "20.0.1"
"@angular/common": "21.0.0",
"@angular/router": "21.0.0",
"@ngrx/store": "21.0.0",
"@ngrx/effects": "21.0.0",
"@ngrx/operators": "21.0.0"
},
"sideEffects": false
}
14 changes: 7 additions & 7 deletions libs/repositories/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
"name": "@frontend/repositories",
"version": "0.0.1",
"peerDependencies": {
"@angular/common": "20.3.0",
"@angular/core": "20.3.0",
"@angular/common": "21.0.0",
"@angular/core": "21.0.0",
"rxjs": "7.8.0",
"@nx/angular": "21.5.2",
"@nx/angular": "22.5.3",
"vite": "6.3.6",
"@analogjs/vite-plugin-angular": "1.21.0",
"@nx/vite": "21.5.2",
"@angular/cdk": "20.2.4",
"@analogjs/vite-plugin-angular": "2.3.0",
"@nx/vite": "22.5.3",
"@angular/cdk": "21.0.0",
"@frontend/shared": "0.0.1",
"@ngrx/signals": "20.0.1"
"@ngrx/signals": "21.0.0"
},
"sideEffects": false
}
12 changes: 6 additions & 6 deletions libs/shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
"name": "@frontend/shared",
"version": "0.0.1",
"peerDependencies": {
"@angular/common": "20.3.0",
"@angular/core": "20.3.0",
"@nx/angular": "21.5.2",
"@angular/common": "21.0.0",
"@angular/core": "21.0.0",
"@nx/angular": "22.5.3",
"vite": "6.3.6",
"@analogjs/vite-plugin-angular": "1.21.0",
"@nx/vite": "21.5.2",
"@angular/forms": "20.3.0",
"@analogjs/vite-plugin-angular": "2.3.0",
"@nx/vite": "22.5.3",
"@angular/forms": "21.0.0",
"apexcharts": "5.3.5"
},
"sideEffects": false
Expand Down
Loading