Add documentation of how to use <.input type="select"> to Core Components #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add this documentation to |
|
Ping :) |
|
Done: phoenixframework/phoenix_html#460 |
|
@ponychicken merged and published! |
|
I left the two examples and replaced the rest with a link to opts_for_select |
josevalim
reviewed
Feb 27, 2025
| @@ -263,10 +263,18 @@ defmodule <%= @web_namespace %>.CoreComponents do | |||
| for more information. Unsupported types, such as hidden and radio, | |||
| are best written directly in your templates. | |||
|
|
|||
| ## Examples | |||
| ## Basic Examples | |||
There was a problem hiding this comment.
I think it is fine to call it examples, no need to change that :)
Suggested change
| ## Basic Examples | |
| ## Examples |
josevalim
reviewed
Feb 27, 2025
| ## Select type | ||
|
|
||
| When using `type="select"`, you must pass the `options` and optionally | ||
| a `value` to mark which option should be preselected. |
There was a problem hiding this comment.
Should we have a quick example just below this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phoenixframework/phoenix_live_view#3197