Skip to content

chore(publish-npm): default Node.js runtime to 24 - #91

Merged
Ryan Zhu (underthestars-zhy) merged 1 commit into
mainfrom
cursor/upgrade-node-24-ff4f
Jul 13, 2026
Merged

chore(publish-npm): default Node.js runtime to 24#91
Ryan Zhu (underthestars-zhy) merged 1 commit into
mainfrom
cursor/upgrade-node-24-ff4f

Conversation

@underthestars-zhy

@underthestars-zhy Ryan Zhu (underthestars-zhy) commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • default publish-npm and publish-npm-packages to Node 24
  • keep the npm upgrade step for OIDC Trusted Publishing (npm >= 11.5.1)
  • update README input defaults to match

This replaces the Node 20 + npm 11 pin approach: Node 24 can run current npm, so OIDC publishing does not need a Node 20-compatible npm major pin. No package/engines changes are required in consuming repos.

Verification

  • confirmed only action defaults and docs changed
  • validated YAML/docs still list node-version consistently as 24
Open in Web Open in Cursor 

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Documentation

    • Updated publishing guidance to reflect Node.js 24 as the default runtime for both single-package and multi-package npm publishing workflows.
    • Clarified the npm version requirement for trusted publishing.
  • Chores

    • Updated publishing workflows to use Node.js 24 by default.

Upgrade the publish-npm and publish-npm-packages action defaults from
Node 20 to Node 24 so OIDC publishing can use current npm without a
Node 20 engine pin.

Co-authored-by: Ryan Zhu <zhuhaoyu0909@icloud.com>
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f042c6d-0647-4185-8c21-05cfcc9cd4aa

📥 Commits

Reviewing files that changed from the base of the PR and between 0f4f42c and 90b3a3c.

📒 Files selected for processing (3)
  • .github/blocks/publish-npm-packages/action.yaml
  • .github/blocks/publish-npm/action.yaml
  • README.md

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

The npm publishing actions now default to Node 24. Their README input tables and OIDC Trusted Publishing comments are updated accordingly, without changing action control flow.

Changes

npm publishing runtime update

Layer / File(s) Summary
Update publishing defaults and documentation
.github/blocks/publish-npm-packages/action.yaml, .github/blocks/publish-npm/action.yaml, README.md
Both publishing actions default to Node 24, OIDC comments describe the npm version requirement, and README tables show the updated default.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A bunny hops through Node’s bright door,
Twenty-four now leads the score.
npm notes are freshly spun,
README tables match the run.
Thump-thump—publishing has begun!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/upgrade-node-24-ff4f

Comment @coderabbitai help to get the list of available commands.

@underthestars-zhy
Ryan Zhu (underthestars-zhy) marked this pull request as ready for review July 13, 2026 02:19
Copilot AI review requested due to automatic review settings July 13, 2026 02:19
@underthestars-zhy
Ryan Zhu (underthestars-zhy) merged commit c3c48ac into main Jul 13, 2026
3 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

📄 README may need an update

This PR introduces changes that might not be reflected in README.md.

Reason: The README does not document the new public publish-command input on .github/blocks/publish-npm/action.yaml, so it no longer fully reflects the current npm publishing configuration surface.

This is an automated check powered by AI. If the README is intentionally unchanged, feel free to ignore this.

@github-actions

Copy link
Copy Markdown

📚 Skills documentation may need an update

This PR introduces changes that might not be reflected in the skills documentation.

Reason: buildspace-ci-cd/SKILL.md does not reflect the updated npm publishing behavior exposed by this PR, especially publish-npm/typescript-service-release support for opt-in npm OIDC Trusted Publishing with id-token: write and NPM_TOKEN as fallback plus the related use-oidc/publish-command guidance.

This is an automated check powered by AI. If the skills are intentionally unchanged, feel free to ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants