Code

Check code for errors and warnings.#114

Code

Closed

devnuhl wants to merge 8 commits intophp-school:masterphp-school/php-workshop:masterfrom

devnuhl:masterdevnuhl/php-workshop:masterCopy head branch name to clipboard

Commits

Commits on May 22, 2016

• exclude warnings from verify output; will still fail on warnings.

  Show description for 4ad9a96
  devnuhl

  committed
  4ad9a96

  Copy full SHA for 4ad9a96

• correct the test.

  devnuhl

  committed
  284372c

  Copy full SHA for 284372c

Commits on May 24, 2016

• Check code for warnings and errors, in both CliRunner and CgiRunner. Ref: #4

  devnuhl

  committed
  1b4b1f9

  Copy full SHA for 1b4b1f9

• phpcs fixes for line length.

  devnuhl

  committed
  e0928fe

  Copy full SHA for e0928fe

Commits on May 28, 2016

• default some parameters that shouldn't affect existing behavior.

  Show description for becc71a
  devnuhl

  committed
  becc71a

  Copy full SHA for becc71a

Commits on May 30, 2016

• With separation, we might only need to call this once. It's only being called once.

  devnuhl

  committed
  f892657

  Copy full SHA for f892657

• This was not something we were throwing, it's straight from php, so no linebreak.

  devnuhl

  committed
  3a03c3d

  Copy full SHA for 3a03c3d

• need to install php-cs-fixer, so i can run it before every commit.

  devnuhl

  committed
  c2397ab

  Copy full SHA for c2397ab