Skip to content

Conversation

@haszi
Copy link
Contributor

@haszi haszi commented Nov 22, 2025

Do not check entities files for XML validity as these are never valid on their own.

@haszi haszi requested a review from alfsb November 22, 2025 19:59
@haszi
Copy link
Contributor Author

haszi commented Nov 22, 2025

Test failures are unrelated to this PR.

@alfsb
Copy link
Member

alfsb commented Nov 23, 2025

Pure XML Entities entities.* files should not exist on doc repositories since the idempotent build project. If there are still some, these need to be deleted. I found only two on doc-pl/reference/dir.

So no, for this change.

But as you are at it, changing broken.php to ignore any paths that contain reference/wkhtmltox/wkhtmltox/bits/ would make the warnings a little better. I was hopeful to move these these bits/ files as entities, so another exception on broken.php would not be necessary, but never got to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants