Skip to content

Conversation

youkidearitai
Copy link
Contributor

@youkidearitai youkidearitai commented Oct 29, 2024

Add grapheme_str_split function.

RFC:

ref: #3872

@youkidearitai youkidearitai force-pushed the php84_grapheme_functions branch from f537398 to 558d71a Compare October 29, 2024 02:49
@youkidearitai youkidearitai force-pushed the php84_grapheme_functions branch from 558d71a to bc5a67a Compare October 29, 2024 05:00
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Besides some minor issue, this looks good to me.

@cmb69 cmb69 merged commit 31e3015 into php:master Oct 30, 2024
2 checks passed
@cmb69
Copy link
Member

cmb69 commented Oct 30, 2024

Thank you!

Girgias added a commit that referenced this pull request Oct 30, 2024
Also use simpara instead of para tags

Follow-up to GH-3956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants