Repository navigation
localtime.xml Change the parameter name + nits - #4820
Merged
Merged
Conversation
kamil-tekiela
requested changes
Oct 15, 2025
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
Jul 22, 2026
lacatoire
reviewed
Jul 22, 2026
lacatoire
approved these changes
Jul 22, 2026
offset never comes back as -1: it holds the position at which parsing ended, on success and on failure alike, verified on PHP 8.5.4 with ext/intl. A value past the end of the string fails immediately without touching it; on localtime() and parse() a negative value does too, while parseToCalendar() exempts -1 from that check. Also finish the prose cleanup on localtime(): mark up the parameter references the rename left behind, qualify the localtime() compatibility claim since tm_yday is 1-based here and 0-based there, and describe the formatter parameter of parse() as the object it has always been.
lacatoire
added a commit
to php/doc-fr
that referenced
this pull request
Sep 1, 2026
…and parseToCalendar (#3465) Translation of php/doc-en#4820 (commit 8871302): on return offset holds the position where parsing ended, whether or not it succeeded, and an out-of-range offset makes parsing fail immediately while leaving offset untouched. The localtime return value is described in full. EN-Revision updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the name
$parse_posmigrated from the source code. It is better to leave the name$offsetin the user land