Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
reference/filter/constants.xmlwith php/doc-en#5243.The warning claiming
FILTER_CALLBACKcannot be combined with any flag becomes a note describing what actually happens: as of PHP 8.1.25 and 8.2.12 the structural flagsFILTER_REQUIRE_ARRAY,FILTER_FORCE_ARRAYandFILTER_REQUIRE_SCALARdo apply, andFILTER_NULL_ON_FAILUREchanges how a structural failure is reported; in earlier versions every flag was ignored. Filter specific flags are always ignored, and since the callback's return value is the result, no flag turns afalsereturned by the callback into&null;or an exception.The
FILTER_VALIDATE_IPdescription also becomes asimpara, as upstream.EN-Revision bumped to 1900175b061e4de78f5ba3e79874e457d7e710a1.
Fixes: #1674