Skip to content

Conversation

Snape3058
Copy link

Please refer to #17598 for more details.

This patch tries to fix the zend_object layout problem for zend_generator according to the requirements since PHP 7.

@dstogov
Copy link
Member

dstogov commented Jan 30, 2025

See the test failures

@TimWolla TimWolla marked this pull request as draft January 30, 2025 16:43
@cmb69
Copy link
Member

cmb69 commented Feb 4, 2025

Before going into the "details" here, we first should decide if this layout change should be done at all. According to #17598 (comment):

I thought we had the zend_object on purpose as the first member on those classes which don't use properties.
The purpose being avoiding useless offset computations and better locality for the trivial refcounting which is always in the first place when zend_object is the first item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants