Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflectionClass::isCloneable(): reduce duplication #17795

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

DanielEScherzer
Copy link
Contributor

When the zend_class_entry has a zend_function entry for clone, the logic is the same regardless of if the reflection_object entry has an object or not; the determination is based solely on the flags of the zend_function.

When the `zend_class_entry` has a `zend_function` entry for `clone`, the logic
is the same regardless of if the `reflection_object` entry has an object or
not; the determination is based solely on the flags of the `zend_function`.
@DanielEScherzer
Copy link
Contributor Author

Test failure appears unrelated:

NMAKE : fatal error U1077: '  "C:\obj\Release_TS\php.exe" -d open_basedir= -d output_buffering=0 run-tests.php -d opcache.enable=1 -d opcache.enable_cli=1 -d opcache.protect_memory=1 -d opcache.jit_buffer_size=64M -d opcache.jit=tracing -g FAIL,BORK,LEAK,XLEAK  --no-progress -q --offline --show-diff --show-slow 1000 --set-timeout 120 --temp-source c:\tests_tmp --temp-target c:\tests_tmp -j2 -p "C:\obj\Release_TS\php.exe"' : return code '0x1'

@iluuu1994 iluuu1994 merged commit 07e5f6f into php:master Feb 14, 2025
8 of 9 checks passed
@iluuu1994
Copy link
Member

Thank you @DanielEScherzer!

@DanielEScherzer DanielEScherzer deleted the patch-3 branch February 14, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants