Reduce number of string duplications in phar #17814
Merged
+21
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to duplicate these strings from the resource, we can just use them with an offset. To prove this was safe, I had to make the arguments const and then propagate that everywhere, so this patch also introduces some more constness.
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Feb 15, 2025
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Feb 15, 2025
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Feb 15, 2025
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Feb 15, 2025
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Feb 15, 2025
nielsdos
added a commit
that referenced
this pull request
Feb 15, 2025
nielsdos
added a commit
that referenced
this pull request
Feb 15, 2025
This reverts commit 619d293. Just Windows things...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to duplicate these strings from the resource, we can just use them with an offset.
To prove this was safe, I had to make the arguments const and then propagate that everywhere, so this patch also introduces some more constness.