ext/curl: CURLOPT_FOLLOWLOCATION option handling. #18444
Closed
+80
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it had been considered as boolean for years but since 8.13, it can accept values beyond 1L, respectively CURLFOLLOW_OBEYCODE and CURLFOLLOW_FIRSTONLY.
nielsdos
reviewed
Apr 27, 2025
devnexen
force-pushed
the
curl_followlocation_upd
branch
from
b118a4b to
0d676b5
Compare
dunglas
approved these changes
Apr 28, 2025
nielsdos
reviewed
Apr 29, 2025
| --FILE-- | ||
| <?php | ||
|
|
||
| for ($i = 0; $i <= CURLFOLLOW_FIRSTONLY; $i ++) { |
There was a problem hiding this comment.
You're making assumptions here about the specific values that these constants have. Unlikely to change, but not a fan to depend on this.
I propose to use a foreach loop with an array containing the values you want to test.
nielsdos
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it had been considered as boolean for years but since 8.13, it can accept values beyond 1L, respectively CURLFOLLOW_OBEYCODE and CURLFOLLOW_FIRSTONLY.